Add support for Foregin keys table in Pstress by rahulmalik87 · Pull Request #92 · Percona-QA/pstress

rahulmalik87 · 2023-08-02T10:01:22Z

Added new table type in pstress with suffix _fk table.
Number of tables depends on fk-prob.
Such table will have column ifk_col reference to a parent table ipkey

for example if --fk-prob is 50 and --tables 100.
there is 50% chance there will be a table tt_N_fk whose parent would be tt_N

Since they linked to pk of parent table. To test FK use --fk-prob=100 --pk-prob=100

To disable foreign keys use --no-fk

Also rename some existing options like

primary-key-probability is now pk-prob
ratio-normal-temp is now temp-prob

Fixed the code around START TRANSACTION. Previously it was running as single transaction which would block transaction on other session.

Decrease the probability of using SAVE POINT in a transaction to 10 % from 25% default

Added new table type in pstress with suffix _fk table. Number of tables depends on fk-prob. Such table will have column ifk_col reference to a parent table ipkey for example if --fk-prob is 50 and --tables 100. there is 50% chance there will be a table tt_N_fk whose parent would be tt_N Since they linked to pk of parent table. To test FK use --fk-prob=100 --pk-prob=100 To disable foreign keys use --no-fk Also rename some existing options like primary-key-probability is now pk-prob ratio-normal-temp is not temp-prob Fixed the code around START TRANSACTION. Previously it was running as single transaction which would block transaction on other session. Decrease the probability of using SAVE POINT in a transaction to 10 % from 25% default Decrease the probablity of partition tables to 10%; Decrease the probablity of temporary tables to 10%;

mohitj1988 · 2023-08-17T04:41:49Z

Hi @rahulmalik87 - Thanks for the pull request. We are looking into it.

mohitj1988 · 2023-08-17T04:44:08Z

    TRANSATION_PRB_K,
    TRANSACTIONS_SIZE,
-    COMMMIT_TO_ROLLBACK_RATIO,
+    COMMMIT_PROB,


Fix the name to "COMMIT_PROB"

mohitj1988 · 2023-08-24T09:59:08Z

@rahulmalik87 - Few observations

| tt_10_fk | CREATE TABLE tt_10_fk(ifk_colint DEFAULT NULL,ipkeyint NOT NULL AUTO_INCREMENT,c1char(24) DEFAULT NULL,v2_renamevarchar(25) DEFAULT NULL,i3int DEFAULT NULL,v5varchar(10) DEFAULT NULL,tN20_renametinyint(1) DEFAULT NULL,gN277 varchar(13) GENERATED ALWAYS AS (concat(substr(v5,1,6),substr(v5,1,2),substr(i3,1,5))) VIRTUAL, iN24int DEFAULT NULL,tN228tinyint(1) DEFAULT NULL,vN179 varchar(24) DEFAULT NULL, PRIMARY KEY (ipkey), KEY tt_10_fk14 (ipkey,v5 DESC,c1,v2_renameDESC), KEYtt_10_fk783 (tN20_rename,c1,gN277), KEY tt_10_fk750_rename (tN20_rename,v5,ipkey,gN277,c1), KEY tt_10_fk389 (i3,gN277DESC), KEYtt_10_fk656 (tN20_rename DESC,v5 DESC,gN277,ipkey,i3,ifk_col) ) /*!50100 TABLESPACE tab16k_e */ ENGINE=InnoDB AUTO_INCREMENT=9959 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_0900_ai_ci COMPRESSION='none' /*!80016 ENCRYPTION='Y' */ |

Tested the patch, but don't see which table the foreign key column is referencing to. Normally a foreign key syntax looks like this

FOREIGN KEY (col1) REFERENCES tt_2(col2)

rahulmalik87 · 2023-08-24T10:12:08Z

Thank you for testing.
Could you help me to replicate the issue, what is the command line option you used?
I tried pstress-ms --socket $SOCKET --tables 10 -fk-prob=100 --jldd
and the fk_table has the
CONSTRAINT tt_5_fk_tt_5 FOREIGN KEY (ifk_col) REFERENCES tt_5 (ipkey) ON DELETE RESTRICT ON UPDATE CASCADE

mohitj1988 · 2023-08-24T10:49:54Z

@rahulmalik87 - Use --tables 10 --records 100 --fk-prob 100 --pk-prob 100 --seconds 10

mohitj1988 · 2023-08-25T05:15:14Z

@rahulmalik87 Some more problems found:

`Test Case1:

./pstress-ps --tables 50 --records 100 --no-temp-tables --no-partition-tables --fk-prob 100 --socket /tmp/mysql_22000.sock --threads 5 --logdir pwd/log

Thread 2 failed, check logs for detail message
Thread 0 failed, check logs for detail message
Thread 1 failed, check logs for detail message
Thread 3 failed, check logs for detail message
Thread 4 failed, check logs for detail message

Error:
F ALTER TABLE tt_12_fk ADD CONSTRAINT tt_12_fk_tt_12 FOREIGN KEY (ifk_col) REFERENCES tt_12 (ipkey) ON UPDATE SET DEFAULT ON DELETE SET DEFAULT
Error Cannot add or update a child row: a foreign key constraint fails (test.#sql-3fe171_1e, CONSTRAINT tt_12_fk_tt_12 FOREIGN KEY (ifk_col) REFERENCES tt_12 (ipkey))
Failed to add fk constraint on tt_12_fk

Test Case 2:

./pstress-ps --tables 10 --records 100 --only-partition-tables --fk-prob 100 --socket /tmp/mysql_22000.sock --threads 5 --logdir pwd/log --jlddl

This creates only one table instead of creating 10 partition tables with FK references

Test Case 3:

./pstress-ps --tables 10 --records 100 --fk-prob 100 --pk-prob 100 --seconds 10 --threads 5 --socket /tmp/mysql_22000.sock --logdir pwd/log

This does not create FK reference tables`

rahulmalik87 · 2023-11-09T07:16:31Z

I have fixed the Test case 1.

Fk table tries to insert entries from previous table and gets an error Failed to add constraint during alter Now if parent table has 0 records, then fk table will also be empty

satya-bodapati · 2024-06-13T12:04:53Z

@rahulmalik87 Thanks for the contribution, can u please look into the other failures?

satya-bodapati · 2024-06-14T10:32:34Z

Thank you @rahulmalik87 for reviving/addressing review comments!

https://perconadev.atlassian.net/browse/PSTRESS-152 Introduced support for Foreign key tables in Pstress. * The tables with foreign key references are suffixed with `_fk` while creating the tables. * These FK tables include `ifk_col` column referencing parent table's `ipkey`. * Example : When --fk-prob is 50 --tables 100 options are passed, there is a 50% chance there will be a table tt_N_fk whose parent would be tt_N. * To fully test FK behaviour, use `--fk-prob=100 --pk-prob=100` * The FK tables can be disabled with `--no-fk` option. Renamed some command-line options for clarity: * `--primary-key-probability` -> `--pk-prob` * `--ration-normal-temp` -> `--temp-prob` Fixed transaction behaviour: * Ensured `START TRANSACTION` doesn't block other sessions by running transactions independently. Adjusted the default probabilities of some features: * Decreased the probability of using SAVEPOINT in a transaction from 25% to 10%. * Decreased the probability of partition tables to 10%. * Decreased the probability of temporary tables to 10%. Thanks Rahul Malik for the contribution. (github.com/Percona-QA/pull/92)

https://perconadev.atlassian.net/browse/PSTRESS-152 Introduced support for Foreign key tables in Pstress. * The tables with foreign key references are suffixed with `_fk` while creating the tables. * These FK tables include `ifk_col` column referencing parent table's `ipkey`. * Example : When --fk-prob is 50 --tables 100 options are passed, there is a 50% chance there will be a table tt_N_fk whose parent would be tt_N. * To fully test FK behaviour, use `--fk-prob=100 --pk-prob=100` * The FK tables can be disabled with `--no-fk` option. Fixed transaction behaviour: * Ensured `START TRANSACTION` doesn't block other sessions by running transactions independently. Adjusted the default probabilities of some features: * A new option called partition-prob is added which controls the number of partition tables created and is set to 10% by default. * The exisiting option ratio-normal-temp is replaced with a new option, temporary-prob to control the number of temporary tables and is set to 10% by default. * The exisiting option commit-rollback-ratio is replaced with a new option, commit-prob, which controls the probability of executing commit and is set to 95 by default. * Decreased the probability of using SAVEPOINT in a transaction from 50% to 10%. * The option `primary-key-probability` is renamed to `--pk-prob` fpr clarity. Thanks Rahul Malik for the contribution. (github.com/Percona-QA/pull/92)

rahulmalik87 force-pushed the percona-ps-master-91 branch from 60e3375 to 6305c08 Compare August 2, 2023 10:02

mohitj1988 reviewed Aug 17, 2023

View reviewed changes

mohitj1988 force-pushed the master branch from b35bcad to 461d553 Compare October 12, 2023 08:34

Fixed a case when parent table does not have records,

b2d7b76

Fk table tries to insert entries from previous table and gets an error Failed to add constraint during alter Now if parent table has 0 records, then fk table will also be empty

rahulmalik87 force-pushed the percona-ps-master-91 branch from c1cf914 to b2d7b76 Compare November 9, 2023 07:58

rahulmalik87 added 2 commits June 14, 2024 10:52

Added fix for testcase

049287b

Added paritition-prob=100 to --only-parititon

4971019

VarunNagaraju mentioned this pull request Jul 10, 2025

Adds support for Foreign keys table in Pstress #101

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Foregin keys table in Pstress#92

Add support for Foregin keys table in Pstress#92
rahulmalik87 wants to merge 4 commits intoPercona-QA:masterfrom
rahulmalik87:percona-ps-master-91

rahulmalik87 commented Aug 2, 2023 •

edited

Loading

Uh oh!

mohitj1988 commented Aug 17, 2023

Uh oh!

mohitj1988 Aug 17, 2023

Uh oh!

mohitj1988 commented Aug 24, 2023

Uh oh!

rahulmalik87 commented Aug 24, 2023

Uh oh!

mohitj1988 commented Aug 24, 2023 •

edited

Loading

Uh oh!

mohitj1988 commented Aug 25, 2023 •

edited

Loading

Uh oh!

rahulmalik87 commented Nov 9, 2023

Uh oh!

satya-bodapati commented Jun 13, 2024

Uh oh!

satya-bodapati commented Jun 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

rahulmalik87 commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohitj1988 commented Aug 17, 2023

Uh oh!

mohitj1988 Aug 17, 2023

Choose a reason for hiding this comment

Uh oh!

mohitj1988 commented Aug 24, 2023

Uh oh!

rahulmalik87 commented Aug 24, 2023

Uh oh!

mohitj1988 commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mohitj1988 commented Aug 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rahulmalik87 commented Nov 9, 2023

Uh oh!

satya-bodapati commented Jun 13, 2024

Uh oh!

satya-bodapati commented Jun 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rahulmalik87 commented Aug 2, 2023 •

edited

Loading

mohitj1988 commented Aug 24, 2023 •

edited

Loading

mohitj1988 commented Aug 25, 2023 •

edited

Loading