Change 5.45 added PERL_UNUSED_ARGs to new UNUSED scheme - #24801
Open
khwilliamson wants to merge 1 commit into
Open
khwilliamson wants to merge 1 commit into
khwilliamson wants to merge 1 commit into
Conversation
I didn't change the ones where it didn't make sense. The new scheme has the advantage that on compilers that know about the __attribute_nonnull__ modifier to parameters, it uses that, falling back to the equivalent of PERL_UNUSED_ARG on other compilers. And the code is somewhat tidier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't change the ones where it didn't make sense.
The new scheme has the advantage that on compilers that know about the attribute_nonnull modifier to parameters, it uses that, falling back to the equivalent of PERL_UNUSED_ARG on other compilers.
And the code is somewhat tidier.
And it addresses https://github.com/Perl/perl5/blob/blead/Porting/todo.pod#weed-out-needless-perl_unused_arg