regen/embed.pl: Separate symbols not always pulled in - #24820
Open
khwilliamson wants to merge 1 commit into
Open
khwilliamson wants to merge 1 commit into
khwilliamson wants to merge 1 commit into
Conversation
Many perl symbols are exposed to XS module namespace. embed.pl has a list of the ones we have yet to decide if they should be exposed, or shouldn't. It turns out that some symbols on that list are not exposed to the typical XS module that uses EXTERN.h, perl.h, and XSUB.h; but only get exposed if the module explicitly #includes another perl header file. It is less important to resolve these than the ones that always are exposed. So this commit splits them out into a separate list, grouped for convenience by the header file they are defined in. This commit brings the always visible unresolved symbol number down to just under 2500, a decrease of 25% from 5.44.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many perl symbols are exposed to XS module namespace. embed.pl has a list of the ones we have yet to decide if they should be exposed, or shouldn't. It turns out that some symbols on that list are not exposed to the typical XS module that uses EXTERN.h, perl.h, and XSUB.h; but only get exposed if the module explicitly #includes another perl header file.
It is less important to resolve these than the ones that always are exposed. So this commit splits them out into a separate list, grouped for convenience by the header file they are defined in.
This commit brings the always visible unresolved symbol number down to just under 2500, a decrease of 25% from 5.44.0