Skip to content

Ijai: Fixes for some models, parser version update#725

Open
maksp86 wants to merge 1 commit into
PiotrMachowski:dev_extracted_librariesfrom
maksp86:alpha-23-ijai-encrypt-fix
Open

Ijai: Fixes for some models, parser version update#725
maksp86 wants to merge 1 commit into
PiotrMachowski:dev_extracted_librariesfrom
maksp86:alpha-23-ijai-encrypt-fix

Conversation

@maksp86

@maksp86 maksp86 commented Feb 15, 2026

Copy link
Copy Markdown

The "isK3" (selects map url) and "isEncryptKeyTypeHex" functions from the Mi Home plugins have been implemented. This will improve the stability of some models and provide support for others.

@PiotrMachowski

Copy link
Copy Markdown
Owner

That's great, thank you!
The one suggestion from my side is that I think isK3 function should be moved to the Map Extractor from ijai_vacuum_map_parser, because it is not used for parsing the map

@Korkuttum

This comment was marked as off-topic.

@PiotrMachowski

Copy link
Copy Markdown
Owner

@Korkuttum it is not related to changes from this PR

@Korkuttum

Copy link
Copy Markdown

I sent it here because I didn’t know this should I open a separate issue?
I still haven’t been able to see the map.

@vit9696

vit9696 commented Jun 9, 2026

Copy link
Copy Markdown

@PiotrMachowski, could you please consider merging this pull request as is and providing an alpha release for easier installation?

Your suggestion makes good sense, but it is purely stylistic, and I believe can be handled in a separate pull request. Given vacuum-map-parser-ijai 0.1.1 is published on pypi.org with several other changes, it feels more beneficial to merge now rather than wait for a stylistic update, especially given that no active development happens in vacuum-map-parser-ijai at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants