Fix reauthentication when vacuum host changes#754
Open
AStotal wants to merge 1 commit into
Open
Conversation
AStotal
marked this pull request as ready for review
July 14, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The confirmation step searched existing config entries using the newly submitted host. During reauthentication that host can differ from the stored value, especially when an entry contains a placeholder or the vacuum received a new IP address. The lookup then returned
None, but the reauthentication branch still dereferencedexisting_entry.data, causing anAttributeErrorthat Home Assistant displayed as an unknown error.Impact
Reauthentication now updates the intended config entry even when its stored host no longer matches. It also replaces a placeholder or outdated unique ID with the MAC address returned by Xiaomi Cloud.
Validation
AttributeErrorbefore the fix and passes after itcompileallandgit diff --check