Skip to content

[PROOFREADING] wallet_section - zh-Hans#4467

Draft
MilankovicProtocol wants to merge 105 commits into
PlanB-Network:devfrom
MilankovicProtocol:patch-42
Draft

[PROOFREADING] wallet_section - zh-Hans#4467
MilankovicProtocol wants to merge 105 commits into
PlanB-Network:devfrom
MilankovicProtocol:patch-42

Conversation

@MilankovicProtocol

@MilankovicProtocol MilankovicProtocol commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

Closes #4263

Mechanical sweeps + targeted regression fixes on top of the contributor's
section pass:

- restore brand names: Blink Wallet (blink), Electrum (electrum)
- fix typos: 结main → 界面 (sparrow), 就应概览 → 交易概览 (bull-bitcoin)
- restore semantic of "tips that dude" quote (electrum)
- complete 投资组合 → 钱包 sweep (13 files; fr→zh false-friend
  portefeuille/portfolio)
- complete 你 → 您 register sweep across the 12 files where both
  pronouns coexisted; preserve 你 in the "Not your keys, not your coins"
  blockquote in breez
- normalize zh-Hant 闪电网路 → 闪电网络 (6 files)
- strip introduced trailing whitespace (10 files)
@Asi0Flammeus

Copy link
Copy Markdown
Collaborator

Hi @MilankovicProtocol, thanks for tackling the entire wallet section in zh-Hans.

I've pushed a small follow-up commit (38197d2) handling what I was confident about:

  • 5 regression fixes: Blink Wallet brand restored in 2 headings (blink), Electrum brand restored where the "E" was dropped, 结main界面 (sparrow), 就应概览交易概览 (bull-bitcoin), and the "tips that dude" quote semantic restored (electrum)
  • finished the 投资组合钱包 sweep (13 files where both terms coexisted)
  • finished the 你 → 您 register sweep (12 files; left 你 only in the "Not your keys, not your coins" blockquote in breez)
  • normalized 闪电网路闪电网络 (6 zh-Hant stragglers)
  • stripped trailing whitespace introduced in 10 files

Before I finalize, a few questions where I'd rather have your call than guess. Based on your answers I'll apply the rest myself — no action needed from you on the code.

Please answer each with intentional / not intentional:

  1. Mnemonic terminology — You introduced 助记词 as the canonical form, but 短语, 恢复短语, and 种子 still coexist in 37–40 files. Did you mean 助记词 to replace all of them, or do you keep a distinction (e.g. 种子 for "seed" vs 助记词 for "mnemonic phrase")? If the latter, can you describe the rule so I can apply it consistently?

  2. English "Bitcoin" still in the prose of 62 files — You introduced 比特币 widely. Was the remaining English "Bitcoin" intentional (e.g. preserving brand contexts like Bitcoin Core, Bull Bitcoin, Bitcoin Beach), or do you want a global sweep of prose-context "Bitcoin" → 比特币 while keeping multi-word brand names intact?

  3. Hardware Wallet → 硬件钱包 — converted in only 4 places; 16 files still use the English form. Intentional, or pending?

  4. 计算机 vs 电脑 ("computer") — both forms coexist in 24 files; you converted 7 instances. Should I sweep to one form, and which?

  5. 初学者 vs 新手 ("beginner") — same situation; you started a sweep but 28 files still mix both. Preferred form?

  6. Quote style — you converted some "…" to "…" and others to backticks for UI labels. Should I normalize to a single style across the section, and which one ("…" curly Chinese quotes, or backticks for UI labels + curly for prose)?

  7. muun and liana — both are still 1st-round zh-Hans candidates in tutorials/wallet/ but absent from this PR. Intentional skip, or coming in a follow-up?

Just let me know on each point and I'll handle the cleanup before merging. Thanks!

@Asi0Flammeus Asi0Flammeus marked this pull request as draft April 30, 2026 10:07
@MilankovicProtocol

Copy link
Copy Markdown
Collaborator Author

Hello asi0, sorry for the late reply, here are the clarifications:

  1. Intentional. 助记词 = refers to the 12/24 words mnemonic phrase, 种子 = refers to the "seed" in cryptographic terms
  2. Intentional. For proper nouns (e.g. brand names) I do not translate the term to Chinese. I only translate Bitcoin to 比特币 when it refers to the bitcoin network/the currency itself
  3. Not intentional. "Hardware wallet" terms should be converted to 硬件钱包,sorry for the overlook 🙏
  4. Intentional. 计算机 is more formal, while 电脑 is less formal and more used in speech. I wanted to have a variety in the terms. However, if you want to sweep into one form for consistency, you can use 计算机.
  5. Intentional. I wanted to have a variety in the terms. If you want to sweep for consistency, I prefer 初学者.
  6. Not intentional. UI labels should use back ticks while quotes should use curly chinese quotes. I apologize for the overlook 🙏.
  7. Intentional. I have proofread those two wallet tutorials before.

Thank you for pointing these out 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PROOFREADING] wallet_section - zh-Hans

2 participants