Don't track stack when in performance test mode#247
Merged
Conversation
…t, you probably don't need the stack information for debugging purposes. Instead, you'll probably be queuing a lot of events, which can be slow if we keep track of the stack info. Signed-off-by: Hin Tse <5867507+hintse@users.noreply.github.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 84.57% 84.83% +0.26%
==========================================
Files 138 138
Lines 14025 14151 +126
Branches 1395 1396 +1
==========================================
+ Hits 11861 12005 +144
+ Misses 1729 1706 -23
- Partials 435 440 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Hin Tse <5867507+hintse@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a performance test, you probably don't need the stack information for debugging purposes. Instead, you'll probably be queuing a lot of events, which can be slow if we keep track of the stack info.