Skip to content

Don't track stack when in performance test mode#247

Merged
timkpaine merged 2 commits into
mainfrom
hin/performance-test-harness
Mar 30, 2026
Merged

Don't track stack when in performance test mode#247
timkpaine merged 2 commits into
mainfrom
hin/performance-test-harness

Conversation

@hintse

@hintse hintse commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

In a performance test, you probably don't need the stack information for debugging purposes. Instead, you'll probably be queuing a lot of events, which can be slow if we keep track of the stack info.

…t, you probably don't need the stack information for debugging purposes. Instead, you'll probably be queuing a lot of events, which can be slow if we keep track of the stack info.

Signed-off-by: Hin Tse <5867507+hintse@users.noreply.github.com>
@github-actions

github-actions Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Test Results

618 tests  +13   610 ✅ +13   7m 12s ⏱️ +2s
  1 suites ± 0     8 💤 ± 0 
  1 files   ± 0     0 ❌ ± 0 

Results for commit 3907f36. ± Comparison against base commit 580acfc.

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Mar 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.56604% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.83%. Comparing base (580acfc) to head (3907f36).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
csp_gateway/testing/harness.py 57.14% 14 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   84.57%   84.83%   +0.26%     
==========================================
  Files         138      138              
  Lines       14025    14151     +126     
  Branches     1395     1396       +1     
==========================================
+ Hits        11861    12005     +144     
+ Misses       1729     1706      -23     
- Partials      435      440       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hintse hintse marked this pull request as ready for review March 26, 2026 13:00
Signed-off-by: Hin Tse <5867507+hintse@users.noreply.github.com>
@timkpaine timkpaine merged commit 8740c3a into main Mar 30, 2026
12 checks passed
@timkpaine timkpaine deleted the hin/performance-test-harness branch March 30, 2026 17:25
@timkpaine timkpaine added type: bug Concrete, reproducible bugs tag: internal Issues and PRs for maintainance of the project - not interesting to external users labels May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tag: internal Issues and PRs for maintainance of the project - not interesting to external users type: bug Concrete, reproducible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants