Skip to content

rework table registry with backwards compatibility, strip theme from js download, bump psp js#284

Merged
timkpaine merged 1 commit into
mainfrom
tkp/cspg
Jun 2, 2026
Merged

rework table registry with backwards compatibility, strip theme from js download, bump psp js#284
timkpaine merged 1 commit into
mainfrom
tkp/cspg

Conversation

@timkpaine

Copy link
Copy Markdown
Member

This change allows registration of multiple perspective tables off the same columns via config.
Also bumps perspective JS for bugfixes and strips theme from perspective workspace config download as its driven at the csp-gateway level via light/dark selector.

…js download, bump psp js

Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit f048021. ± Comparison against base commit ea0def1.

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.86047% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.38%. Comparing base (ea0def1) to head (f048021).

Files with missing lines Patch % Lines
csp_gateway/server/modules/web/perspective.py 84.78% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #284      +/-   ##
==========================================
+ Coverage   87.32%   87.38%   +0.06%     
==========================================
  Files         142      142              
  Lines       14469    14635     +166     
==========================================
+ Hits        12635    12789     +154     
- Misses       1834     1846      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timkpaine timkpaine marked this pull request as ready for review June 2, 2026 16:36
@timkpaine timkpaine merged commit 3b9041b into main Jun 2, 2026
12 checks passed
@timkpaine timkpaine deleted the tkp/cspg branch June 2, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants