fix(client): support legacy wallet gasless execution - #183
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 766d709. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Verification
Note
Medium Risk
Changes signed RelayHub fields and relay address for Proxy gasless txs, which can break relayer validation if estimates or params are wrong; live integration tests increase env/credential dependence but do not alter production auth paths for deposit wallets.
Overview
Fixes legacy Proxy gasless signing so RelayHub parameters match what the relayer expects.
Proxy workflow now sets
gasLimitfrometh_estimateGason the encoded factory call (replacing a fixed placeholder) and uses the relayer’sexecuteParams.addressas the relay in the signed hash instead of the zero address.Adds
JsonRpcClient.ethEstimateGas(with a unit test) to support that estimation.Integration tests drop MSW submit-shape assertions in favor of live end-to-end gasless runs for Proxy and Safe wallets via
approveErc20andwait(), using builder API auth. The deposit wallet signer fixture is wired through the shared private-key fixture.Reviewed by Cursor Bugbot for commit 544fdcd. Bugbot is set up for automated code reviews on this repo. Configure here.