feat(client): support Perps cancel-all orders - #184
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a843149. Configure here.
| .then(expectNonEmptyArray); | ||
| const [ticker] = await publicClient | ||
| .fetchPerpsTickers({ instrumentId: instrument.id }) | ||
| .then(expectNonEmptyArray); |
There was a problem hiding this comment.
Module load hits live Perps API
Medium Severity
Hoisting fetchPerpsInstruments and fetchPerpsTickers to top-level await runs two live Perps REST calls when the module loads. All cases use it.runIf(runMeteredTests), so with metered tests off Vitest still evaluates the file and can fail collection on network or empty data before any test is skipped.
Reviewed by Cursor Bugbot for commit a843149. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
session.cancelAllOrders({ instrumentId?, expiresAt? }){ status: "ok" }response and export the new request typeVerification
pnpm lintpnpm typecheckpnpm test:bindingspnpm test:clientpnpm exec vitest --project client-integration packages/client/tests/integration/perps.test.ts --run(metered tests skipped unless enabled)Rollout note
The live cancel-all integration test depends on the backend endpoint being deployed.
Note
Medium Risk
Introduces a bulk trading cancel on live Perps accounts; behavior is accept-on-ACK with possible races on individual orders, and depends on the backend cancel-all endpoint being deployed.
Overview
Adds
session.cancelAllOrders({ instrumentId?, expiresAt? })so Perps users can cancel every open order account-wide or for one instrument, via a signed RESTDELETE /v1/trade/orders/all(unlike single/batch cancels over the session WebSocket).The client builds a
cancelAllsigned op, serializes optionaliidin the request body, validates{ status: "ok" }, and exportsCancelAllPerpsOrdersRequestfrom bindings and public entry points.PerpsSessionTradingErrornow includes rate-limit and unexpected-response failures for this path.Also bumps
ORDER_PLACEMENT_UPDATE_TIMEOUT_MSfrom 1s to 2s, adds MSW coverage for scoped vs global cancel-all payloads, and a metered integration test that places two orders then cancel-all for one instrument.Reviewed by Cursor Bugbot for commit a843149. Bugbot is set up for automated code reviews on this repo. Configure here.