fix(client): strengthen CLOB price read types - #203
Merged
cesarenaldi merged 3 commits intoJul 15, 2026
Conversation
cesarenaldi
deleted the
feature/dev-416-return-decimalstring-from-fetchprice
branch
July 15, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Medium Risk
Public TypeScript return types change from
stringand loose records to brandedDecimalStringandTokenId-keyed maps, which can break downstream consumers at compile time even though runtime parsing behavior is largely unchanged.Overview
Tightens CLOB price read typings across
@polymarket/bindingsand@polymarket/clientso validated API data is not widened to plainstringmaps at the boundary.Bindings:
MidpointsSchema,PricesSchema, andSpreadsSchemanow key results byTokenIdinstead of arbitrary strings. BatchfetchPricesshapes are modeled as partialOrderSide→DecimalStringrecords (only requested sides present), with runtime tests for valid parses and rejection of unknown side keys.Client: Single-token helpers (
fetchMidpoint,fetchPrice,fetchSpread) returnDecimalString; batch helpers returnMidpoints,Prices, andSpreads. TheDataActionsdecorator surface matches those types. New compile-time tests lock the public API; integration tests assert token-keyed batch results and that unrequested sell sides stay absent onfetchPrices.Patch changesets cover DEV-416 (branded decimals) and DEV-417 (token-keyed batch maps).
Reviewed by Cursor Bugbot for commit b1d5a5a. Bugbot is set up for automated code reviews on this repo. Configure here.