fix(client): re-export OrderPostStatus from the root entry point - #346
Open
naruto11eth wants to merge 1 commit into
Open
fix(client): re-export OrderPostStatus from the root entry point#346naruto11eth wants to merge 1 commit into
naruto11eth wants to merge 1 commit into
Conversation
AcceptedOrderResponse.status is typed with it, but only the type was reachable from @polymarket/client; comparing against a member forced an import from the internal bindings package. Our own integration tests were doing exactly that.
naruto11eth
requested review from
cesarenaldi and
kartojal
and removed request for
cesarenaldi
September 2, 2026 11:24
kartojal
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcceptedOrderResponse.statusis typed asOrderPostStatus, but the root entry point only re-exported the enum as a type, not as a value. Comparing against a member,response.status === OrderPostStatus.MATCHED, forced consumers to import from@polymarket/bindings/clob, a package documented as not for direct use. Our own integration tests were doing exactly that.This adds
OrderPostStatusto the existing@polymarket/bindings/clobvalue-export block, alongsideOrderResponseErrorCodefrom the same file, and switches the three integration tests to import it from@polymarket/client.Changeset:
@polymarket/clientpatch.Fixes #344