Skip to content

fix form-url-encoding data (body) for nested objects#150

Open
filipkowicz wants to merge 1 commit into
PolymerElements:masterfrom
filipkowicz:master
Open

fix form-url-encoding data (body) for nested objects#150
filipkowicz wants to merge 1 commit into
PolymerElements:masterfrom
filipkowicz:master

Conversation

@filipkowicz

Copy link
Copy Markdown

Fixes #149

Fixes #149 with calling urlencoding method recurrently on nested objects (preserving parent's keys)

Test provided for presented case.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@filipkowicz

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@filipkowicz

Copy link
Copy Markdown
Author

hi, it makes this element usable for me. Please take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants