Manage request as an upload#243
Open
Westbrook wants to merge 9 commits into
Open
Conversation
Author
|
Any update on this? |
Author
|
Ping? |
|
@Westbrook FWIW, I implemented this on my own and for some reason the progress property is not propagating up to the iron-ajax element. very weird. |
Author
|
@btelles Implemented from my fork? Did you instal via bower.json? I had a pita of a time getting bower to recognize that as the version to use vs the ones pointed to in other dependencies. If you are working from my code I'd be glad to hear your experience and see if we can't find the right changes to support a wide set of users for this. I actually just released my feature based on these changes this morning, but I could have easily been working around something on accident in my own code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also in reference to #235.
This is a first pass at this PR as I have a number of questions about what form a more complete implementation should be.
Here I've added an
isUploadproperty to both theiron-ajaxandiron-uploadso that when it is set totruethe listener iniron-requestthat updates theprogressproperty is attached toxhr.uploadinstead of justxhr. This allows the implementer to track file uploads into the UI, etc.First, I'm wondering if when uploading all events tracked in
send()should be pointed toxhr.upload. Second, should this actually be an even greater change where theprogressobject be duplicated intouploadProgressanddownloadProgressso that both objects and listeners can be tracked at all times?Once that is figured out, I'd look for insight on good ways to add tests for this. There doesn't seem to be any test in
iron-requestfor progress, and this seems like it might be a good place to do so?