Skip to content

check against serialized objects and test wrapper in CI - #1

Merged
Neopallium merged 1 commit into
mainfrom
patch9
Apr 30, 2026
Merged

check against serialized objects and test wrapper in CI#1
Neopallium merged 1 commit into
mainfrom
patch9

Conversation

@lovesh

@lovesh lovesh commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Neopallium
Neopallium merged commit 9e7d5de into main Apr 30, 2026
3 of 4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an integration test suite that verifies current proof/serialization output against committed “v1” serialized vectors to catch breaking changes, and updates CI/docs to support running these checks.

Changes:

  • Introduces serialized_objects_test integration test crate with shared helpers/constants and proof/vector generators (ignored by default).
  • Commits a tests/serialized_objects/v1 set of SCALE/canonical-serialized golden files used by the tests.
  • Updates CI workflow to run polymesh-dart formatting/tests; updates docs and gitignore to retain the committed vectors.

Reviewed changes

Copilot reviewed 23 out of 93 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/serialized_objects_test/utils.rs Helper IO + deterministic RNG/key helpers for loading/saving vectors
tests/serialized_objects_test/main.rs Ignored “generate vectors” entrypoint for v1 fixtures
tests/serialized_objects_test/fee.rs Generates + verifies fee-related proofs against v1 vectors
tests/serialized_objects_test/constants.rs Centralizes v1 directory, seeds, filenames, and common constants
tests/serialized_objects/v1/settlement_proof_revealed_asset_id.bin Adds v1 serialized test vector
tests/serialized_objects/v1/settlement_proof_parties_hidden.bin Adds v1 serialized test vector
tests/serialized_objects/v1/settlement_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_reverse_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_reverse_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_reverse_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_counter_update_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_counter_update_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_counter_update_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_affirm_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_affirm_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/sender_affirm_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_counter_update_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_counter_update_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_counter_update_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_affirm_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_affirm_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/receiver_affirm_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/mint_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/mint_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/mint_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/mediator_encryption.bin Adds v1 serialized test vector
tests/serialized_objects/v1/leg_encrypted.bin Adds v1 serialized test vector
tests/serialized_objects/v1/key_distribution_proof_3_recipients.bin Adds v1 serialized test vector
tests/serialized_objects/v1/key_distribution_proof_2_recipients.bin Adds v1 serialized test vector
tests/serialized_objects/v1/key_distribution_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/instant_sender_affirm_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/instant_sender_affirm_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/instant_sender_affirm_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/instant_receiver_affirm_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/instant_receiver_affirm_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_topup_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_topup_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_topup_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_reg_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_reg_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_reg_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_payment_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_payment_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_payment_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_account_topup_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_account_registration_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_account_payment_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/encryption_key_registration_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/encryption_key_pair.bin Adds v1 serialized test vector
tests/serialized_objects/v1/dart_bp_generators.bin Adds v1 serialized test vector
tests/serialized_objects/v1/claim_received_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/claim_received_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/claim_received_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/fee_account_registration_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/batched_fee_account_registration_proof_3.bin Adds v1 serialized test vector
tests/serialized_objects/v1/batched_fee_account_registration_proof_2.bin Adds v1 serialized test vector
tests/serialized_objects/v1/batched_account_asset_registration_proof_3.bin Adds v1 serialized test vector
tests/serialized_objects/v1/batched_account_asset_registration_proof_2.bin Adds v1 serialized test vector
tests/serialized_objects/v1/asset_minting_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/asset_commitment_parameters.bin Adds v1 serialized test vector
tests/serialized_objects/v1/asset_commitment_data_enc_1_med_1.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_state_nullifier.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_state_commitment.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_state.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_registration_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_reg_split_response.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_reg_split_request.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_reg_split_proof.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_public_keys.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_keys.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_key_pair.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_asset_state_with_pending.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_asset_state_no_pending.bin Adds v1 serialized test vector
tests/serialized_objects/v1/account_asset_registration_proof.bin Adds v1 serialized test vector
src/bp/keys.rs Exposes a getter for the wrapped account signing key
src/bp/fee.rs Removes large commented-out alternative proof construction block
dart-bp/src/account/mint.rs Removes an unused commented field from proof struct
dart-bp/src/account/common/verifier.rs Factors tuple handling into handle_verification_tuples helper
README.md Documents serialized-vector test usage and coverage commands
.gitignore Keeps committed serialized-object .bin vectors from being ignored
.github/workflows/dart-bp-tests.yml Adds polymesh-dart fmt + test steps in CI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants