Adds singleton property to modulescripts - #1061
Draft
JustBorgar wants to merge 1 commit into
Draft
Conversation
Signed-off-by: JustBorgar <134341430+JustBorgar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Singletonproperty to module scripts, allowing them to run on their own, which is useful for imperative scripts that need to share state via signals, but don't necessarily need any input (eg. a MusicZones script withState/Sound/Playlistproperties and their respectiveChangedsignals).Property is basically the equivalent of parenting a server and a client script to the module with this one liner:
Which is not hard to do but clutters the file browser.
Related issue or discussion
None, this is mostly made as a throwaway proof of concept. If this were to be added it'd probably need an enum to pick which contexts the module would autorun on (saw no demand for this one so I didn't bother with that).
Type of change
Area affected
Checklist
dotnet restoredotnet formatdotnet builddotnet test --project Polytoria.Tests/Polytoria.Tests.csprojAI/LLM use
Claude was used for drafting, code review/cleanup, and troubleshooting. All code was manually reviewed and tested.