Remove Performance as default rendering method - #1161
Open
svendyy wants to merge 1 commit into
Open
Conversation
Signed-off-by: svendyy <a4riven@proton.me>
Author
|
If anyone is against this, then I believe it would be more productive to express your concerns and arguments, rather than reacting to the PR implying that there is something wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverted the change that made Performance the default rendering method, because Performance RM has stricter lighting limitations, which can break lighting in some games.
Related issue or discussion
Related to #1062
Type of change
Area affected
Checklist
dotnet restoredotnet formatdotnet builddotnet test --project Polytoria.Tests/Polytoria.Tests.csprojScreenshots / video
Here you can see a game being affected by this. First screenshot shows the map in Standard rendering method, and second shows in Performance, where the facility lights basically don't illuminate the map.
This PR removes Performance as the default rendering method, so Auto can use Godot's default rendering behavior again and games don't get broken lighting like this by default.
In games where lighting matters for gameplay, this is not only a visual issue. In my case, players on Auto currently default to Performance on supported hardware and basically get no facility lighting at all, while Standard works normally. This gives them a visibility disadvantage and also makes restoring main power look like it did nothing.
AI/LLM use
Used AI to help me with this PR since I'm still pretty new to development outside of Polytoria scripting and don't know C#. I mostly used it to understand the relevant code and contribution process. I reviewed the previous RM change myself and tested this change locally
Additional notes
I understand that RM default was changed to improve performance, but currently, it is not ideal because Performance may sometimes break lighting. It also has other rendering limitations/quality differences compared to Standard. I think the proper solution should be developing a system that would pick the best RM individually for each player, while letting developers detect the actual RM players are using and being able to enforce one if needed.