.Net 10 changes for reference#2026
Open
renemadsen wants to merge 1329 commits intoPomeloFoundation:mainfrom
Open
.Net 10 changes for reference#2026renemadsen wants to merge 1329 commits intoPomeloFoundation:mainfrom
renemadsen wants to merge 1329 commits intoPomeloFoundation:mainfrom
Conversation
This test is expected to throw InvalidOperationException due to EF Core issue #31776, which affects type mapping inference when using Contains with local enumerables that have inline closures. This is consistent with the SQL Server provider implementation. The error "Conflicting type mappings were inferred for column 'Value'" occurs when EF Core tries to infer type mappings for a ValuesExpression in complex Contains queries. This is a known limitation tracked in dotnet/efcore#31776. Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ters test for MySQL Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
… MariaDB Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…windBulkUpdatesMySqlTest Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
MySQL 8.0.40 changed JSON key ordering behavior - it now sorts keys alphabetically when storing/retrieving JSON data. Additionally, MySQL requires CAST(@param AS json) for JSON comparisons, while MariaDB does not. Updated three tests to use conditional SQL assertions based on server type: - JsonMicrosoftDomQueryTest.Parameter_document - JsonMicrosoftDomQueryTest.Parameter_element - JsonNewtonsoftDomQueryTest.Parameter_element Tests now pass on both MySQL 8.0.40 and MariaDB 11.3.2+ Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…expectations for MySQL 8.0.14+ Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ryMySqlTest Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
….40+ Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…Parameter_document Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
The tests incorrectly expected MySQL to throw error 1093 for DELETE queries with derived tables. The SQL pattern generated by EF Core uses derived tables (AS `o1`) within EXISTS clauses, which materializes the intermediate result and avoids MySQL's error 1093 "You can't specify target table for update in FROM clause". This pattern works on both MySQL and MariaDB. Fixed tests: - Delete_Where_Take - Delete_Where_Skip - Delete_Where_Skip_Take - Delete_Where_OrderBy_Skip - Delete_Where_OrderBy_Take - Delete_Where_OrderBy_Skip_Take - Delete_Where_Skip_Take_Skip_Take_causing_subquery Tests now pass on both MySQL 8.0.40 and MariaDB 11.6.2. Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…nheritance_derived_type Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…ent-overrides Add missing test override for Subquery_over_primitive_collection_on_inheritance_derived_type
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
….Test.Sdk-18.3.0 Bump Microsoft.NET.Test.Sdk from 18.0.1 to 18.3.0
--- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis dependency-version: 5.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
- Update Microsoft.CodeAnalysis.CSharp from 4.14.0 to 5.3.0 - Update Microsoft.CodeAnalysis.CSharp.Features from 4.14.0 to 5.3.0 - Update Microsoft.CodeAnalysis.CSharp.Workspaces from 4.14.0 to 5.3.0 - Update Microsoft.CodeAnalysis.VisualBasic.Features from 4.14.0 to 5.3.0 - Add Microsoft.CodeAnalysis.Workspaces.MSBuild 5.3.0 to Directory.Packages.props - Add direct PackageReference for Workspaces.MSBuild in Tests and IntegrationTests to override the 5.0.0 version pulled in transitively by EF Core Design 10.0.3 Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/0eebb69a-c47f-4ffa-b48e-18354a3ff801 Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…eAnalysis-5.3.0 Bump Microsoft.CodeAnalysis from 5.0.0 to 5.3.0
--- updated-dependencies: - dependency-name: GitHubActionsTestLogger dependency-version: 3.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…TestLogger-3.0.2 Bump GitHubActionsTestLogger from 3.0.1 to 3.0.2
--- updated-dependencies: - dependency-name: GitHubActionsTestLogger dependency-version: 3.0.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
--- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-version: 18.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ing.EntityFrameworkCore.MySql Changes: - Updated AssemblyName in 4 src .csproj files - Updated assembly name references in 9 .targets files (kept namespace-qualified type names unchanged) - Updated debug info keys in MySqlOptionsExtension.cs - Updated test assertions and references in 3 test files - Added breaking change notice to README.md - Updated README.md references to use the new assembly name Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/ac058a11-4867-4d19-b31a-8874efad5daa Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/ac058a11-4867-4d19-b31a-8874efad5daa Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
- Renamed all C# namespaces from Pomelo.EntityFrameworkCore.MySql to Microting.EntityFrameworkCore.MySql - Updated RootNamespace in all .csproj files - Updated PomeloTargetFramework -> MicrotingTargetFramework build property - Updated Directory.Build.props (Company, Copyright, Product, StrongNameKeyId, PackageTags) - Updated .targets files type-qualified names - Updated copyright headers and doc comments - Updated all docs/, samples/, benchmark/ references - Updated NuGet.config (removed old Pomelo AZDO/MyGet feeds) - Updated LICENSE copyright - Updated scaffold.ps1 and legacy migration backups - Updated stylecop.json companyName - Updated README.md breaking change notice for full rename Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/e67cb5d3-ed73-4e71-9761-6c6d2bb856be Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
… in migration instructions Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/e67cb5d3-ed73-4e71-9761-6c6d2bb856be Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
… rename The namespace rename from Pomelo to Microting changed the alphabetical sort order of using statements: Microting (M) now sorts before NetTopologySuite (N), whereas Pomelo (P) sorted after it. Updated 4 baseline files in BigModel and BigModel_with_JSON_columns to match the code generator output. Agent-Logs-Url: https://github.com/microting/Pomelo.EntityFrameworkCore.MySql/sessions/02852c37-2af9-4f3f-819c-6039c7680517 Co-authored-by: renemadsen <76994+renemadsen@users.noreply.github.com>
…TestLogger-3.0.3 Bump GitHubActionsTestLogger from 3.0.2 to 3.0.3
….Test.Sdk-18.4.0 Bump Microsoft.NET.Test.Sdk from 18.3.0 to 18.4.0
…-intended Fully rename all Pomelo references to Microting across entire codebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lauxjpn Use for refference as you wish.
Let me know in what slices you want the changes to be put into different smaller PR's for you to better use the changes.
I've kept all the existing db versions and added new versions to demonstrate that no regressions are there.
To my best of knowledge and testing, all changes are working.
Also implemented ToJson() instead of the custom json implementation, since I personally don't like custom out of scope changes => more custom code to maintain, than following the mainline => easier to maintain.