Fixes in order to restore SaveSearcher temporarily while waiting for rewrite#60
Open
SilverBeamx wants to merge 4 commits intoPorkStudios:0.5.4-SNAPSHOTfrom
Open
Fixes in order to restore SaveSearcher temporarily while waiting for rewrite#60SilverBeamx wants to merge 4 commits intoPorkStudios:0.5.4-SNAPSHOTfrom
SilverBeamx wants to merge 4 commits intoPorkStudios:0.5.4-SNAPSHOTfrom
Conversation
Author
|
@DaMatrix Sorry for the ping, i don't know if you are still checking notifications for this project. As i stated in the PR description. this changes are mainly aimed at fixing issues i encountered with running SaveSearcher on a 1.12.2 modded savefile. All changes have been tested by rebuilding SaveSearcher against the fixed PorkLib. If you want to i can share with you the save where all these 3 issues were encountered for verification on your part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses some issues that prevent SaveSearcher from properly working. While i know that SaveSearcher is on hold while waiting for the WorldLib rewrite, this PR enables usage for regular users in the meantime. Changes: