Document CI failure in GenerateFloatRandom function - #1157
Merged
Conversation
Added comment regarding CI failure due to implicit conversion. This PR was created so we can fix the CI failure.
Collaborator
Author
|
CI "CMake build / macOS-Clang" Error: /Users/runner/work/portaudio/portaudio/examples/paex_ocean_shore.c:395:58: error: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-const-int-float-conversion] |
philburk
commented
Jun 25, 2026
philburk
left a comment
philburk
left a comment
Collaborator
Author
There was a problem hiding this comment.
Trying to fix the error through a GitHub suggestion.
This may fix the CI errors.
Collaborator
Author
|
My last commit fixed the Mac OS CI builds. |
Removed comment about CI failure regarding implicit conversion.
Collaborator
Author
|
I made this a P1 high priority because CI was broken. |
RossBencina
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comment regarding CI failure due to implicit conversion.
This PR was created so we can fix the CI failure.