Fix MCP tool contracts - #116
Draft
portswigger-penguin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
443.0for integer parameters and ignore undeclared client argumentsRoot cause
Schema generation treated Kotlin nullability as requiredness, while
kotlinx.serializationtreats constructor defaults as optionality. Nullable properties without defaults—most visiblytabName—were therefore advertised as optional but rejected during deserialization. Other constraints were neither represented in schemas nor checked consistently before reaching downstream APIs.Impact
Schema-respecting MCP clients can omit optional values safely, clients that encode whole numbers as JSON decimals remain compatible, and invalid tool calls receive an MCP error with a concrete correction instead of an exception or successful-looking string.
Validation
./gradlew testCloses #109