Skip to content

feat(hogli): add is_posthog_dev telemetry property#53801

Draft
rnegron wants to merge 3 commits intomasterfrom
rauln/hogli-metrics-identify-posthog-dev
Draft

feat(hogli): add is_posthog_dev telemetry property#53801
rnegron wants to merge 3 commits intomasterfrom
rauln/hogli-metrics-identify-posthog-dev

Conversation

@rnegron
Copy link
Copy Markdown
Member

@rnegron rnegron commented Apr 8, 2026

Problem

The hogli DevEx dashboard mixes PostHog engineer usage with external contributor usage. There's no way to filter by audience, making it hard to understand internal adoption vs community usage.

Changes

Adds a boolean is_posthog_dev event property to all hogli telemetry events. Detected by checking if git config user.email ends with @posthog.com. The actual email is never sent -- just a boolean.

How did you test this code?

  • Unit tests for _is_posthog_dev() covering: PostHog email, non-PostHog email, git config failure, subprocess exception
  • Full test suite passes (38 tests)

No manual testing beyond unit tests -- this was agent-authored.

No changelog, no docs update.

LLM context

Agent-authored PR. Claude Code session.

return None


@functools.lru_cache(maxsize=1)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caching here!

@tests-posthog
Copy link
Copy Markdown
Contributor

tests-posthog bot commented Apr 8, 2026

⏭️ Skipped snapshot commit because branch advanced to 41cb021 while workflow was testing accb144.

The new commit will trigger its own snapshot update workflow.

If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:

  • Merge master into your branch, or
  • Push an empty commit: git commit --allow-empty -m 'trigger CI' && git push

@tests-posthog
Copy link
Copy Markdown
Contributor

tests-posthog bot commented Apr 8, 2026

Query snapshots: Backend query snapshots updated

Changes: 1 snapshots (1 modified, 0 added, 0 deleted)

What this means:

  • Query snapshots have been automatically updated to match current output
  • These changes reflect modifications to database queries or schema

Next steps:

  • Review the query changes to ensure they're intentional
  • If unexpected, investigate what caused the query to change

Review snapshot changes →

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

🎭 Playwright report · View test results →

⚠️ 3 flaky tests:

  • Can create a new dashboard with an insight (chromium)
  • Edit mode button enters and exits edit mode (chromium)
  • Materialize view pane (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this comment? Help fix flakies and failures and it'll disappear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant