feat(clickhouse): add support for data_cluster to override shard discovery for DATA nodes#53823
Draft
feat(clickhouse): add support for data_cluster to override shard discovery for DATA nodes#53823
data_cluster to override shard discovery for DATA nodes#53823Conversation
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We use autodiscovery of nodes for a cluster
posthog_migrations.I hand verified that this cluster often lacks multiple nodes and this causes lot of troubles.
Changes
Use statically defined
posthogcluster for DATA nodes.How did you test this code?
Added some tests. Run desired functions against prod cluster topology.