fix(test): Fix editor wait after insight removal#53826
Open
mendral-app[bot] wants to merge 1 commit intomasterfrom
Open
fix(test): Fix editor wait after insight removal#53826mendral-app[bot] wants to merge 1 commit intomasterfrom
mendral-app[bot] wants to merge 1 commit intomasterfrom
Conversation
…meout
After removeInsightNode() deletes the insight via double Backspace, the
TipTap editor can be left without any contenteditable paragraph. The
NotebookTrailingParagraph extension creates a paragraph on click of the
editor container, but the test was clicking getByRole('textbox') which
requires the contenteditable element to already exist.
Fix by clicking the .NotebookEditor container first to trigger paragraph
creation, then waiting for the textbox to become visible before
interacting with it.
Contributor
|
Size Change: 0 B Total Size: 128 MB ℹ️ View Unchanged
|
sampennington
approved these changes
Apr 9, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notebooks.spec.ts:123("Remove an insight from a notebook and verify text persists") that has been failing ~68 times across 22 days with a 90s timeout onnotebook.editor.click()removeInsightNode()deletes the insight via double Backspace, the TipTap editor is left without anycontenteditableparagraph. TheNotebookTrailingParagraphextension creates a paragraph on click of the editor container, but the test was clickinggetByRole('textbox')which requires the contenteditable element to already exist — causing the timeout.NotebookEditorcontainer first to trigger paragraph creation, then waits for the textbox to become visible before interactingRelated
Note
Created by Mendral. Tag @mendral-app with feedback or questions.