Skip to content

fix: Backfills raise on invalid filter error#53827

Merged
tomasfarias merged 1 commit intomasterfrom
fix/backfills-raise-on-invalid-filter-error
Apr 9, 2026
Merged

fix: Backfills raise on invalid filter error#53827
tomasfarias merged 1 commit intomasterfrom
fix/backfills-raise-on-invalid-filter-error

Conversation

@tomasfarias
Copy link
Copy Markdown
Contributor

Problem

get_backfill_info retries forever with an invalid filter.

Changes

Make it fail on InvalidFilterError.

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Publish to changelog?

Docs update

@tomasfarias tomasfarias requested a review from rossgray April 9, 2026 08:48
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 9, 2026

Vulnerabilities

No security concerns identified.

Reviews (1): Last reviewed commit: "fix: Backfills raise on invalid filter e..." | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@rossgray rossgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@tests-posthog
Copy link
Copy Markdown
Contributor

tests-posthog bot commented Apr 9, 2026

Query snapshots: Backend query snapshots updated

Changes: 1 snapshots (1 modified, 0 added, 0 deleted)

What this means:

  • Query snapshots have been automatically updated to match current output
  • These changes reflect modifications to database queries or schema

Next steps:

  • Review the query changes to ensure they're intentional
  • If unexpected, investigate what caused the query to change

Review snapshot changes →

@tomasfarias tomasfarias force-pushed the fix/backfills-raise-on-invalid-filter-error branch from 7ba6e0b to 679ffa9 Compare April 9, 2026 09:16
@tomasfarias tomasfarias enabled auto-merge (squash) April 9, 2026 09:17
@tomasfarias tomasfarias merged commit f502c3f into master Apr 9, 2026
130 checks passed
@tomasfarias tomasfarias deleted the fix/backfills-raise-on-invalid-filter-error branch April 9, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants