Protocol support for Bedrock 1.16.0#293
Merged
Polyana-Fontes merged 158 commits intomasterfrom Jul 1, 2020
Merged
Conversation
…w-raknet � Conflicts: � src/main/java/cn/nukkit/level/generator/Flat.java � src/main/java/cn/nukkit/level/generator/Nether.java � src/main/java/cn/nukkit/level/generator/Normal.java
…kit into pr/new-raknet
Merge commits from master
* Implement end portal creation * Import Vector3
…stMC#1505) This should allow chunks to load if invalid blocks are contained within it.
Member
Author
|
At this point, there are no known issues with walls, please, test them, test all possible connections both on side and above, it's important because the chunks will be updated proactively only once, this means that if the wall don't behave perfectly now, the players will have to break and place the walls or cause block updates to them to fix missing or incorrect connections. |
Polyana-Fontes
commented
Jun 30, 2020
Member
Author
Polyana-Fontes
left a comment
Polyana-Fontes
left a comment
There was a problem hiding this comment.
I marked all tagging, testing and adjustments that I found while reviewing.
| - [#293] `SetSpawnPositionPacket.spawnForce` is now unused and will be removed on `1.4.0.0-PN` | ||
| - [#293] `TextPacket.TYPE_JSON` was renamed to `TYPE_OBJECT` and will be removed on `1.4.0.0-PN` | ||
| - [#293] `riderInitiated` argument was added to the `EntityLink` constructor. The old constructor will be removed on `1.4.0.0-PN` | ||
|
|
Member
Author
There was a problem hiding this comment.
Needs to be updated
This comment has been minimized.
This comment has been minimized.
# Conflicts: # src/main/java/cn/nukkit/Server.java # src/main/java/cn/nukkit/network/Network.java # src/main/java/cn/nukkit/network/RakNetInterface.java
According to GamePedia, quartz_bricks is 559. Leaving 41 free to allow expansion and custom blocks.
Polyana-Fontes
commented
Jul 1, 2020
Member
Author
Polyana-Fontes
left a comment
Polyana-Fontes
left a comment
There was a problem hiding this comment.
Everything looks fine
Polyana-Fontes
added
Resolution: resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will add protocol support to the current version of PowerNukkit.
Currently tracking NukkitX#1507
This is a child task of #290 and solves #291