jeez#1152
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates dependency references in the project configuration and modifies the startup script for the Slackbot example.
- Updated the "slackbot" dependency in pyproject.toml to use a git reference for "raggy[tpuf]".
- Commented out reload functionality in examples/slackbot/start.py.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Changed dependency reference for the "raggy[tpuf]" package. |
| examples/slackbot/start.py | Commented out reload-related parameters in the app startup. |
Comments suppressed due to low confidence (1)
pyproject.toml:52
- [nitpick] Verify that switching to a git URL for the 'raggy[tpuf]' dependency is intentional as it may introduce version instability compared to using a versioned release.
"raggy[tpuf]@git+https://github.com/zzstoatzz/raggy.git",
Comment on lines
+18
to
+19
| # reload=settings.test_mode, | ||
| # reload_dirs=["examples/slackbot"] if settings.test_mode else None, |
There was a problem hiding this comment.
[nitpick] If the reload functionality is no longer necessary, consider removing the commented-out code to improve code clarity, or reinstate it if it was disabled by mistake.
Suggested change
| # reload=settings.test_mode, | |
| # reload_dirs=["examples/slackbot"] if settings.test_mode else None, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.