Team.get_agentlet: accept and forward active_mcp_servers#1220
Closed
romans127 wants to merge 2 commits into
Closed
Team.get_agentlet: accept and forward active_mcp_servers#1220romans127 wants to merge 2 commits into
romans127 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a TypeError that occurs when using Team objects with the orchestrator by adding MCP server support to the Team class. The orchestrator passes active_mcp_servers to get_agentlet(), which Agent supports but Team previously did not, causing a signature mismatch.
- Add
active_mcp_serversparameter toTeam.get_agentlet()method signature - Forward the parameter to the active member's
get_agentlet()call - Add unit test to verify proper parameter forwarding
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/marvin/agents/team.py | Adds MCPServer import and active_mcp_servers parameter to get_agentlet() method with proper forwarding |
| tests/agents/test_team_mcp_forward.py | Adds unit test to verify MCP servers parameter is correctly forwarded to active team member |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
Conceded to #1219 identical solution, but handles documentation + examples. Well done 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Fixes a TypeError when using Team with the orchestrator. The orchestrator passes active_mcp_servers into actor.get_agentlet(...). Agent.get_agentlet supports this parameter, but Team.get_agentlet did not accept or forward it, causing a mismatch.
Changes:
Backwards compatibility: Optional parameter only; no breaking changes.
Motivation: Ensures teams work with MCP integration through the orchestrator, aligning Team with Actor/Agent signatures.