Skip to content

Add skeleton loader for Followed by section on profile details #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AleksandarIlic merged 1 commit into from
Jul 8, 2026
Merged

Add skeleton loader for Followed by section on profile details #1088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 52 additions & 7 deletions app/src/main/kotlin/net/primal/android/profile/details/ui/ProfileDetailsHeader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,17 @@ import androidx.compose.animation.fadeIn
import androidx.compose.animation.fadeOut
import androidx.compose.animation.shrinkVertically
import androidx.compose.foundation.background
import androidx.compose.foundation.border
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.shape.CircleShape
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.SnackbarDuration
import androidx.compose.material3.SnackbarHostState
Expand Down Expand Up @@ -54,6 +56,7 @@ import net.primal.android.core.compose.AvatarOverlap
import net.primal.android.core.compose.AvatarThumbnailsRow
import net.primal.android.core.compose.IconText
import net.primal.android.core.compose.NostrUserText
import net.primal.android.core.compose.PulsingListItemPlaceholder
import net.primal.android.core.compose.preview.PrimalPreview
import net.primal.android.core.compose.profile.model.ProfileDetailsUi
import net.primal.android.core.compose.profile.model.ProfileStatsUi
Expand Down Expand Up @@ -259,11 +262,8 @@ private fun ProfileHeaderDetails(
onProfileClick = onProfileClick,
)
} else {
Spacer(
modifier = Modifier
.padding(vertical = 8.dp)
.fillMaxWidth()
.height(36.dp),
UserFollowedByIndicatorPlaceholder(
modifier = Modifier.padding(horizontal = 14.dp, vertical = 8.dp),
)
}
}
Expand Down Expand Up @@ -291,7 +291,7 @@ private fun UserFollowedByIndicator(
avatarOverlap = AvatarOverlap.Start,
avatarBorderSize = 1.dp,
avatarSize = 36.dp,
maxAvatarsToShow = 5,
maxAvatarsToShow = FOLLOWED_BY_AVATAR_COUNT,
displayAvatarOverflowIndicator = false,
)
val text =
Expand All @@ -306,6 +306,51 @@ private fun UserFollowedByIndicator(
}
}

@Composable
private fun UserFollowedByIndicatorPlaceholder(modifier: Modifier = Modifier) {
Row(
horizontalArrangement = Arrangement.spacedBy(8.dp),
verticalAlignment = Alignment.CenterVertically,
modifier = modifier,
) {
val avatarSize = 36.dp
val avatarSpacing = avatarSize * (1f - FOLLOWED_BY_AVATAR_OVERLAP)
Box(
modifier = Modifier.size(
width = avatarSpacing * (FOLLOWED_BY_AVATAR_COUNT - 1) + avatarSize,
height = avatarSize,
),
) {
for (index in FOLLOWED_BY_AVATAR_COUNT - 1 downTo 0) {
Box(
modifier = Modifier
.padding(start = avatarSpacing * index)
.size(avatarSize)
.border(
width = 1.dp,
color = AppTheme.colorScheme.background,
shape = CircleShape,
),
) {
PulsingListItemPlaceholder(
height = avatarSize,
width = avatarSize,
shape = CircleShape,
)
}
}
}
PulsingListItemPlaceholder(
modifier = Modifier.weight(1f),
height = 32.dp,
shape = AppTheme.shapes.small,
)
}
}

private const val FOLLOWED_BY_AVATAR_COUNT = 5
private const val FOLLOWED_BY_AVATAR_OVERLAP = 0.25f

@Composable
private fun ProfileFollowIndicators(
modifier: Modifier = Modifier,
Expand Down
Loading