Skip to content

refactor: propagate shared config via before validator #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikasenghaas wants to merge 6 commits into
base: main
Choose a base branch
from
+325 −204
Open

refactor: propagate shared config via before validator #2291

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f66066
refactor: propagate shared model config via before validator
mikasenghaas Apr 16, 2026
9ee6cbe
test: add shared model name propagation test for RLConfig
mikasenghaas Apr 17, 2026
dc1818f
refactor: expand auto_setup_shared_configs to cover all shared fields
mikasenghaas Apr 17, 2026
377ae10
refactor: extract validate_shared_seq_len and move None-skip guard to…
mikasenghaas Apr 17, 2026
a61e1d4
cleanup
mikasenghaas Apr 17, 2026
1077bcc
fix: propagate shared configs to tyro-constructed sub-configs
mikasenghaas Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/prime_rl/configs/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,6 +1088,12 @@ def auto_setup_tokenizer(self):
self.tokenizer.trust_remote_code = self.model.trust_remote_code
return self

@model_validator(mode="after")
def auto_setup_session_headers(self):
"""Ensure X-Session-ID header is always set for sticky DP-aware routing at the inference router."""
self.client.extra_headers_from_state.setdefault("X-Session-ID", "example_id")
return self

@model_validator(mode="after")
def validate_unique_filter_types(self):
types = [f.type for f in self.filters]
Expand Down
Loading
Loading