-
Notifications
You must be signed in to change notification settings - Fork 265
Nixl weight transfer #2326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
S1ro1
wants to merge
47
commits into
main
Choose a base branch
from
nixl-weight-transfer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nixl weight transfer #2326
Changes from 5 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
4a7a6dd
Initial
S1ro1 f270cac
Feat: Cleanup
S1ro1 cd3a565
Clean up GLM MoE DSA converter + NIXL broadcast
S1ro1 612429f
Feat: some cleanup
S1ro1 bec06a0
Feat: cleanup more
S1ro1 459f19f
wtf did claude cook
S1ro1 690dc4a
Feat: NIXL broadcast working end-to-end on GLM-5.1 (12-node disagg)
S1ro1 0d49320
Feat: hard-override UCX_NET_DEVICES in pin_ucx_rail
S1ro1 18b39fe
Feat: NIXL weight transfer now works with expandable_segments=True
S1ro1 5ea1051
Feat: ConversionSpec + QuantizationSpec, doc, fix tilelang preload
S1ro1 ea791f8
Feat: TransportPlan + Slot refactor, drop FP8 NCCL quantize path
S1ro1 90c4dc4
Docs: NIXL architecture contract + drop stale fixtures
S1ro1 e78fa10
Docs: rewrite nixl-weight-broadcast.md as a system contract
S1ro1 ed71964
Docs: drop nixl-architecture.md, superseded by contract rewrite
S1ro1 3a47826
Fix: typo
S1ro1 4369d21
Feat: HSDP support (primary-replica push) + EP partition assertion
S1ro1 f23d68b
Fix: FP8 scale floor back to 1e-12 to match pre-Triton parity
S1ro1 81be8e7
Doc: KL mismatch investigation scratchpad
S1ro1 4df14cc
Exp iter2: add end-to-end signature diagnostic for anchor slot
S1ro1 2740cd3
Exp iter3: expand SIG diagnostic to FP8 gather + expert anchors
S1ro1 a1bcc7d
Exp iter4: inference SIG lookup checks both param + buffer dicts
S1ro1 8f41149
Exp iter5 (doc): disable DeepGemm to test layout-mismatch hypothesis
S1ro1 9cd8541
Exp iter6: SIG now logs shape+stride on both sides
S1ro1 da5e072
Exp iter7: fused-region sum check + multiple expert anchors
S1ro1 60a78f5
Exp iter8: transport non-layer tensors (embed, norm, lm_head)
S1ro1 cd9ff66
Exp iter9: untracked-keys diagnostic for missing slots
S1ro1 37fc774
Exp iter10: cuda.synchronize on inference after SPG barrier
S1ro1 d341bd6
Exp iter11 (doc): enforce_eager=true on inference
S1ro1 0813d85
Exp iter12: verify N anchors (embed/norm/lm_head) transport
S1ro1 d6cca80
Exp iter13: precise ShardedSlot verification via head[:2420] sum
S1ro1 0af021b
Exp iter14 (nixl side): flush_every=1 (per-write drain)
S1ro1 71d24b0
Exp iter14 (doc): maximum conservatism — stack all knobs
S1ro1 68dcfb4
Investigation wrap-up: exhausted surface-level NIXL hypotheses
S1ro1 c494158
Exp iter15: pre-write SPG barrier + inference cuda.sync before it
S1ro1 3e53fa6
Exp iter16: byte-level trainer/inference dump + diff tool
S1ro1 658f3cc
Exp iter17: pause clear_cache=true — test KV cache staleness theory
S1ro1 9035914
Exp iter18: swap Triton FP8 quantize for main's PyTorch impl
S1ro1 6a6a23f
Exp iter19: abort in-flight requests on pause
S1ro1 b29bae3
Revert "Exp iter19: abort in-flight requests on pause"
S1ro1 94edaf7
Exp iter19: flush GPUDirect RDMA writes on inference
S1ro1 a2f81ab
Exp iter20: per-write drain with GPUDirect flush
S1ro1 b053f67
Revert "Exp iter20: per-write drain with GPUDirect flush"
S1ro1 121782b
Exp iter21: enable sync memops on NIXL buffers
S1ro1 6f4a685
Exp iter22-27 (squash): freeze_{experts,non_experts} + transfer_mode …
S1ro1 1c9fe0c
Doc: wrap-up — iter22-27 summary, iter26/27 W&B data, bug narrowed to…
S1ro1 94b6ad6
Doc: rule out inference non-determinism
S1ro1 94c14f4
Remove tools/inference_dashboard from tracking
S1ro1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| """vLLM worker extension that receives weight updates over NIXL. | ||
|
|
||
| Counterpart to :mod:`prime_rl.trainer.rl.broadcast.nixl`. The inference side | ||
| registers parameter memory directly with NIXL (zero-copy RDMA target), | ||
| publishes its expert-ownership map per FusedMoE module, and sits on a | ||
| single process-group barrier per sync while the trainer posts writes. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from typing import TYPE_CHECKING, Any | ||
|
|
||
| import torch | ||
| from torch.nn import Module | ||
| from vllm.distributed.utils import StatelessProcessGroup | ||
| from vllm.logger import init_logger | ||
|
|
||
| from prime_rl.inference.vllm.worker.weight_transfer import build_expert_map, update_mla_absorbed_weights | ||
| from prime_rl.utils.nixl_transfer import NixlAgentWrapper, make_agent_name | ||
|
|
||
| if TYPE_CHECKING: | ||
| from vllm.v1.worker.gpu_worker import Worker # noqa: F401 | ||
|
|
||
| Worker = Worker # type: ignore | ||
| else: | ||
| Worker = object # type: ignore | ||
|
|
||
| logger = init_logger("vllm.inference.vllm.worker_nixl") | ||
|
|
||
|
|
||
| def _iter_transfer_targets(model: Module): | ||
| """Yield (name, tensor) for every parameter + weight-scale buffer we want to | ||
| receive from the trainer. | ||
|
|
||
| vLLM stores FP8 scales as buffers (``w13_weight_scale_inv`` / ``w2_weight_scale_inv``), | ||
| not parameters, so ``named_parameters()`` alone is insufficient. | ||
| """ | ||
| seen: set[str] = set() | ||
| for name, param in model.named_parameters(): | ||
| seen.add(name) | ||
| yield name, param.data | ||
| for name, buf in model.named_buffers(): | ||
| if name in seen: | ||
| continue | ||
| # Only ship weight scales — other buffers (rotary embeddings, caches) are not | ||
| # synchronized from the trainer. | ||
| if name.endswith("_weight_scale_inv"): | ||
| yield name, buf | ||
|
|
||
|
|
||
| class NIXLWeightUpdateWorker(Worker): | ||
| """vLLM worker extension for in-place weight updates over NIXL.""" | ||
|
|
||
| def init_nixl_transfer( | ||
| self, | ||
| host: str, | ||
| port: int, | ||
| rank_offset: int, | ||
| trainer_world_size: int, | ||
| inference_world_size: int, | ||
| timeout: int, | ||
| backends: list[str], | ||
| ) -> None: | ||
| """Register local parameter memory and rendezvous with the trainer.""" | ||
| local_rank = self.device.index | ||
| global_rank = trainer_world_size + rank_offset + local_rank | ||
| full_world_size = trainer_world_size + inference_world_size | ||
|
|
||
| logger.info( | ||
| f"Initializing NIXL transfer: local_rank={local_rank} rank_offset={rank_offset} " | ||
| f"global_rank={global_rank} trainer_ws={trainer_world_size} inference_ws={inference_world_size}" | ||
| ) | ||
|
|
||
| model_runner = self.model_runner | ||
| model = model_runner.model.runnable if hasattr(model_runner.model, "runnable") else model_runner.model | ||
| assert isinstance(model, Module) | ||
| self._model = model | ||
|
|
||
| self._agent = NixlAgentWrapper( | ||
| name=make_agent_name("inference", global_rank), | ||
| local_rank=local_rank, | ||
| backends=backends, | ||
| ) | ||
|
|
||
| # Register every receivable tensor and record its serialized descriptor so the | ||
| # trainer can deserialize it on the other side. | ||
| descriptors: dict[str, bytes] = {} | ||
| for name, tensor in _iter_transfer_targets(model): | ||
| desc = self._agent.register_tensor(tensor.contiguous()) | ||
| descriptors[name] = self._agent.serialize_descs(desc) | ||
|
cursor[bot] marked this conversation as resolved.
Outdated
|
||
|
|
||
| # Expert ownership per FusedMoE module. Re-use the existing helper — each entry | ||
| # is a tensor of global expert indices that this worker holds (sorted by local slot). | ||
| expert_map = {k: v.cpu().tolist() for k, v in build_expert_map(model).items()} | ||
|
|
||
| self._spg = StatelessProcessGroup.create( | ||
| host=host, | ||
| port=port, | ||
| rank=global_rank, | ||
| world_size=full_world_size, | ||
| store_timeout=timeout, | ||
| ) | ||
|
|
||
| my_info = { | ||
| "role": "inference", | ||
| "global_rank": global_rank, | ||
| "agent_name": self._agent.name, | ||
| "agent_metadata": self._agent.get_metadata(), | ||
| "descriptors": descriptors, | ||
| "expert_map": expert_map, | ||
| } | ||
| all_info: list[dict[str, Any]] = self._spg.all_gather_obj(my_info) | ||
|
|
||
| # Add every trainer agent so future WRITEs from them can land here. | ||
| for peer in all_info[:trainer_world_size]: | ||
| self._agent.add_remote(peer["agent_metadata"]) | ||
|
|
||
| logger.info( | ||
| f"NIXL transfer ready: registered {len(descriptors)} tensors, " | ||
| f"added {trainer_world_size} trainer peers" | ||
| ) | ||
|
|
||
| @torch.no_grad() | ||
| def update_weights_from_path(self, weight_dir: str | None = None) -> None: | ||
| """Receive one round of NIXL writes and repost-process the model. | ||
|
|
||
| The actual data movement is driven entirely by the trainer: writes land | ||
| directly in the already-registered parameter memory. We only need to | ||
| wait on the end-of-sync barrier and recompute MLA absorbed weights. | ||
| """ | ||
| if not hasattr(self, "_spg"): | ||
| raise RuntimeError("NIXL transfer not initialized — call /init_nixl_transfer first") | ||
| logger.debug("Waiting for NIXL end-of-sync barrier") | ||
| self._spg.barrier() | ||
| logger.debug("NIXL writes complete, running postprocess") | ||
| update_mla_absorbed_weights(self._model) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed config field without CHANGELOG entry
Medium Severity
The
quantize_in_weight_transferfield is removed fromNCCLWeightBroadcastConfig(trainer),NCCLWeightBroadcastConfig(orchestrator), andSharedWeightBroadcastConfig. Existing user configs (e.g., the example inexamples/glm5_pd_disag/rl.tomlpreviously had this field set) that includequantize_in_weight_transferwill fail Pydantic validation at startup. This is a breaking config removal without a correspondingCHANGELOG.mdentry.Additional Locations (2)
src/prime_rl/configs/orchestrator.py#L782-L792src/prime_rl/configs/rl.py#L151-L163Triggered by project rule: BugBot Instructions
Reviewed by Cursor Bugbot for commit 94b6ad6. Configure here.