Skip to content

chore: rename deprecated orchestrator config keys#2327

Merged
mikasenghaas merged 1 commit intomainfrom
chore/rename-deprecated-config-keys
Apr 19, 2026
Merged

chore: rename deprecated orchestrator config keys#2327
mikasenghaas merged 1 commit intomainfrom
chore/rename-deprecated-config-keys

Conversation

@mikasenghaas
Copy link
Copy Markdown
Member

@mikasenghaas mikasenghaas commented Apr 19, 2026

Summary

  • Rename [orchestrator.sampling][orchestrator.train.sampling] and [[orchestrator.env]][[orchestrator.train.env]] across all configs
  • Rename max_tokensmax_completion_tokens in sampling sections
  • Drops reliance on the deprecated auto-translation emitted by the orchestrator config validator

Validation

  • Ran uv run rl @ <config> --dry-run on all 38 modified RL configs — no deprecation warnings
  • Validated the two orchestrator-only partial configs (configs/debug/orch.toml, configs/ci/integration/rl_multi_run/orchestrator.toml) via direct OrchestratorConfig.model_validate — no deprecation warnings

🤖 Generated with Claude Code


Note

Low Risk
Low risk: this is a mechanical rename of TOML config keys/fields to match the current orchestrator schema, with no functional code changes. Main risk is mis-typed keys causing configs to be ignored or validation to fail at runtime.

Overview
Updates training configs across configs/ and examples/ to stop using deprecated orchestrator keys.

Specifically renames [orchestrator.sampling] to [orchestrator.train.sampling], [[orchestrator.env]] to [[orchestrator.train.env]] (and similarly for orchestrator-only partial configs), and replaces max_tokens with max_completion_tokens in sampling sections.

Reviewed by Cursor Bugbot for commit 6ce2707. Bugbot is set up for automated code reviews on this repo. Configure here.

Rename '[orchestrator.sampling]' -> '[orchestrator.train.sampling]',
'[[orchestrator.env]]' -> '[[orchestrator.train.env]]', and
'max_tokens' -> 'max_completion_tokens' across all configs to remove
reliance on the deprecated auto-translation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mikasenghaas mikasenghaas requested a review from samsja April 19, 2026 16:10
@mikasenghaas mikasenghaas marked this pull request as ready for review April 19, 2026 16:10
@mikasenghaas mikasenghaas merged commit d2718f5 into main Apr 19, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants