chore: rename deprecated orchestrator config keys#2327
Merged
mikasenghaas merged 1 commit intomainfrom Apr 19, 2026
Merged
Conversation
Rename '[orchestrator.sampling]' -> '[orchestrator.train.sampling]', '[[orchestrator.env]]' -> '[[orchestrator.train.env]]', and 'max_tokens' -> 'max_completion_tokens' across all configs to remove reliance on the deprecated auto-translation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
samsja
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[orchestrator.sampling]→[orchestrator.train.sampling]and[[orchestrator.env]]→[[orchestrator.train.env]]across all configsmax_tokens→max_completion_tokensin sampling sectionsValidation
uv run rl @ <config> --dry-runon all 38 modified RL configs — no deprecation warningsconfigs/debug/orch.toml,configs/ci/integration/rl_multi_run/orchestrator.toml) via directOrchestratorConfig.model_validate— no deprecation warnings🤖 Generated with Claude Code
Note
Low Risk
Low risk: this is a mechanical rename of TOML config keys/fields to match the current orchestrator schema, with no functional code changes. Main risk is mis-typed keys causing configs to be ignored or validation to fail at runtime.
Overview
Updates training configs across
configs/andexamples/to stop using deprecated orchestrator keys.Specifically renames
[orchestrator.sampling]to[orchestrator.train.sampling],[[orchestrator.env]]to[[orchestrator.train.env]](and similarly for orchestrator-only partial configs), and replacesmax_tokenswithmax_completion_tokensin sampling sections.Reviewed by Cursor Bugbot for commit 6ce2707. Bugbot is set up for automated code reviews on this repo. Configure here.