Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR adds the eval name from the metadata to the eval push if it was set by the user
Note
Low Risk
Low risk: small change limited to naming derived from
metadata.json, with no changes to API calls or data processing beyond selecting the eval display name.Overview
When loading a local eval directory, the CLI now prefers an explicit eval name from
metadata.json(viaeval_nameorname) instead of always generating"<env>-<model>".If the provided name is missing/empty/non-string, it falls back to the previous default generated name.
Reviewed by Cursor Bugbot for commit 8655f61. Bugbot is set up for automated code reviews on this repo. Configure here.