Skip to content

Revert "vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen"#1200

Open
willccbb wants to merge 1 commit intomainfrom
revert-1183-worktree-deprecate-d-flag
Open

Revert "vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen"#1200
willccbb wants to merge 1 commit intomainfrom
revert-1183-worktree-deprecate-d-flag

Conversation

@willccbb
Copy link
Copy Markdown
Member

@willccbb willccbb commented Apr 20, 2026

Reverts #1183


Note

Medium Risk
Renames and repurposes CLI/config flags controlling logging and the Rich display, which is user-facing and may break existing scripts or TOML configs expecting the previous --disable-tui/--fullscreen behavior.

Overview
Restores the eval CLI’s display/logging flags to --tui/-u (alternate-screen TUI mode) and --debug/-d (disable Rich/TUI; use normal logging + tqdm), updating docs and tests accordingly.

Plumbs the rename through config/schema and runtime execution: EvalConfig.disable_tui becomes EvalConfig.debug, run_evaluations_tui() now takes tui_mode, and env-server console_logging is driven by debug.

Reviewed by Cursor Bugbot for commit cd863d7. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit cd863d7. Configure here.


async def run_evaluations_tui(
config: EvalRunConfig, fullscreen: bool = False, compact: bool = False
config: EvalRunConfig, tui_mode: bool = True, compact: bool = False
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default for tui_mode changed from False to True

Medium Severity

The run_evaluations_tui function's tui_mode parameter default was changed from False (as fullscreen had before this revert) to True. This means any caller that doesn't explicitly pass tui_mode will now get alternate-screen (fullscreen) mode by default, which is the opposite of the previous behavior. The CLI call site in eval.py passes args.tui explicitly so it's unaffected, but this changes the public API contract for anyone calling the function directly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit cd863d7. Configure here.

Copy link
Copy Markdown
Member

@mikasenghaas mikasenghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, i like how it is on current main (unsurprisingly) but if you feel strongly let's revert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants