Revert "vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen"#1200
Revert "vf-eval: replace -d/--debug with --disable-tui, rename --tui to --fullscreen"#1200
Conversation
…to --ful…" This reverts commit ca07020.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cd863d7. Configure here.
|
|
||
| async def run_evaluations_tui( | ||
| config: EvalRunConfig, fullscreen: bool = False, compact: bool = False | ||
| config: EvalRunConfig, tui_mode: bool = True, compact: bool = False |
There was a problem hiding this comment.
Default for tui_mode changed from False to True
Medium Severity
The run_evaluations_tui function's tui_mode parameter default was changed from False (as fullscreen had before this revert) to True. This means any caller that doesn't explicitly pass tui_mode will now get alternate-screen (fullscreen) mode by default, which is the opposite of the previous behavior. The CLI call site in eval.py passes args.tui explicitly so it's unaffected, but this changes the public API contract for anyone calling the function directly.
Reviewed by Cursor Bugbot for commit cd863d7. Configure here.
mikasenghaas
left a comment
There was a problem hiding this comment.
well, i like how it is on current main (unsurprisingly) but if you feel strongly let's revert


Reverts #1183
Note
Medium Risk
Renames and repurposes CLI/config flags controlling logging and the Rich display, which is user-facing and may break existing scripts or TOML configs expecting the previous
--disable-tui/--fullscreenbehavior.Overview
Restores the eval CLI’s display/logging flags to
--tui/-u(alternate-screen TUI mode) and--debug/-d(disable Rich/TUI; use normal logging +tqdm), updating docs and tests accordingly.Plumbs the rename through config/schema and runtime execution:
EvalConfig.disable_tuibecomesEvalConfig.debug,run_evaluations_tui()now takestui_mode, and env-serverconsole_loggingis driven bydebug.Reviewed by Cursor Bugbot for commit cd863d7. Bugbot is set up for automated code reviews on this repo. Configure here.