Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion verifiers/envs/experimental/composable/harnesses/rlm.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def rlm_harness(
append_to_system_prompt: str | None = None,
local_checkout: str | Path | None = None,
gh_token: str | None = None,
disable_compaction: bool = False,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs update for new user-facing kwarg

Low Severity

The new disable_compaction kwarg on rlm_harness() modifies user-facing functionality for RLMEnv, which is described in docs/environments.md. The project rule requires corresponding documentation updates when core user-facing functionality described in docs is added or modified. The PR description itself contains valuable context about the two compaction mechanisms (auto-compaction via RLM_MAX_TURNS_IN_CONTEXT and model-callable summarize tool) that would be useful reference material — the rule notes such information belongs in docs/faqs.md if it doesn't fit elsewhere.

Fix in Cursor Fix in Web

Triggered by project rule: BugBot Instructions

Reviewed by Cursor Bugbot for commit 4120679. Configure here.

) -> Harness:
upload_dir_mapping: dict[str, str] = {
DEFAULT_RLM_CHECKOUT_UPLOAD_NAME: DEFAULT_RLM_CHECKOUT_PATH,
Expand All @@ -116,6 +117,10 @@ def get_upload_dirs() -> dict[str, Traversable | Path]:
resolved_upload_dirs = upload_dirs
return resolved_upload_dirs

tool_names = list(DEFAULT_RLM_TOOL_NAMES)
if disable_compaction:
tool_names = [t for t in tool_names if t != "summarize"]

return Harness(
install_script=build_install_script(),
run_command=build_run_command(instruction_path, workdir),
Expand All @@ -128,5 +133,5 @@ def get_upload_dirs() -> dict[str, Traversable | Path]:
metrics_path="{workdir}/.rlm/sessions/*/meta.json",
metrics_key="metrics",
metrics_prefix="rlm_",
tool_names=list(DEFAULT_RLM_TOOL_NAMES),
tool_names=tool_names,
)
Loading