Apply fixes for Magik language by sebastiaanspeck · Pull Request #4076 · PrismJS/prism

sebastiaanspeck · 2026-04-13T09:45:15Z

No description provided.

netlify · 2026-04-13T09:45:21Z

✅ Deploy Preview for dev-prismjs-com ready!

Name	Link
🔨 Latest commit	`0c9ed13`
🔍 Latest deploy log	https://app.netlify.com/projects/dev-prismjs-com/deploys/69e7c4c4f7e2f600085ff64e
😎 Deploy Preview	https://deploy-preview-4076--dev-prismjs-com.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-13T09:45:40Z

No JS Changes

Generated by 🚫 dangerJS against 0c9ed13

sebastiaanspeck · 2026-04-13T09:45:50Z

#4075 and #4073 are included in this PR (and extended with more fixes)

sebastiaanspeck · 2026-04-14T13:03:37Z

@DmitrySharabin as requested, a new PR which contains all found fixes.

DmitrySharabin

I left some comments/questions. Please, take a look. I'd also suggest adding a few tests to catch the mentioned cases if they make sense.

Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>

sebastiaanspeck · 2026-04-19T02:21:13Z

@DmitrySharabin I resolved your comments. Can you have a look if it looks good to you?

Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com>

DmitrySharabin

LGTM!

Nit: Could you run Prettier, please, on the updated files? It seems like it should fix some formatting issues.

sebastiaanspeck · 2026-04-21T14:38:06Z

Nit: Could you run Prettier, please, on the updated files? It seems like it should fix some formatting issues.

You mean on the test files?

➜  prism git:(fix/magik) npx prettier tests/languages/magik/*
tests/languages/magik/boolean_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/boolean_feature.test".
tests/languages/magik/builtin_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/builtin_feature.test".
tests/languages/magik/char_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/char_feature.test".
tests/languages/magik/comment_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/comment_feature.test".
tests/languages/magik/constant_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/constant_feature.test".
tests/languages/magik/declaration_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/declaration_feature.test".
tests/languages/magik/dynamic-variable_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/dynamic-variable_feature.test".
tests/languages/magik/function_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/function_feature.test".
tests/languages/magik/global-reference_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/global-reference_feature.test".
tests/languages/magik/global-variable_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/global-variable_feature.test".
tests/languages/magik/keyword-operator_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/keyword-operator_feature.test".
tests/languages/magik/keyword-variable_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/keyword-variable_feature.test".
tests/languages/magik/keyword_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/keyword_feature.test".
tests/languages/magik/number_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/number_feature.test".
tests/languages/magik/operator_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/operator_feature.test".
tests/languages/magik/pragma_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/pragma_feature.test".
tests/languages/magik/punctuation_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/punctuation_feature.test".
tests/languages/magik/regex_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/regex_feature.test".
tests/languages/magik/self_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/self_feature.test".
tests/languages/magik/slot_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/slot_feature.test".
tests/languages/magik/string_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/string_feature.test".
tests/languages/magik/symbol_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/symbol_feature.test".
tests/languages/magik/unset_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/unset_feature.test".
tests/languages/magik/variable_feature.test
[error] No parser could be inferred for file "/Users/sebastiaan.speck/src/prism/tests/languages/magik/variable_feature.test".

DmitrySharabin · 2026-04-21T14:45:01Z

Yeah, I think it won't work on the test files. Let's just run Prettier on magik.js. It should be enough.

sebastiaanspeck · 2026-04-21T17:42:34Z

Yeah, I think it won't work on the test files. Let's just run Prettier on magik.js. It should be enough.

Which issues does it solve then? I ran it, but IMO the output was less readable than what we have now.

DmitrySharabin · 2026-04-21T17:58:45Z

Yeah, I think it won't work on the test files. Let's just run Prettier on magik.js. It should be enough.

Which issues does it solve then? I ran it, but IMO the output was less readable than what we have now.

One is that if anyone ever wants to change the file, save the changes, and Prettier kicks in automatically (as it should according to the recommended IDE setup), they should undo the changes made by Prettier or commit/submit unrelated changes.
For example, if we introduce a new feature in Prism and we need the languages to adopt it, we tweak the language definitions. And before we added Prettier, we had many unrelated changes in the corresponding commits (that was a pain; trust me, once, I had to update all the languages Prism supports 😅). We try to avoid it. And yes, Prettier rules are opinionated, but we are fine with them in this project.

I should've asked you to do that in the first PR, but I somehow missed it.

sebastiaanspeck · 2026-04-21T18:26:12Z

Yeah, I think it won't work on the test files. Let's just run Prettier on magik.js. It should be enough.

Which issues does it solve then? I ran it, but IMO the output was less readable than what we have now.

One is that if anyone ever wants to change the file, save the changes, and Prettier kicks in automatically (as it should according to the recommended IDE setup), they should undo the changes made by Prettier or commit/submit unrelated changes.

For example, if we introduce a new feature in Prism and we need the languages to adopt it, we tweak the language definitions. And before we added Prettier, we had many unrelated changes in the corresponding commits (that was a pain; trust me, once, I had to update all the languages Prism supports 😅). We try to avoid it. And yes, Prettier rules are opinionated, but we are fine with them in this project.

I should've asked you to do that in the first PR, but I somehow missed it.

I'll run it then and put aside my own opinion.

DmitrySharabin · 2026-04-21T19:51:22Z

Merged! Thank you.

sebastiaanspeck · 2026-04-22T04:01:13Z

@DmitrySharabin I backported the changes to a branch for v1 so we can use Magik already in several plugins, but with the current grammar, the lint breaks, while in v2 it doesn't.

https://github.com/sebastiaanspeck/prism/actions/runs/24758384791

DmitrySharabin · 2026-04-22T07:08:07Z

@DmitrySharabin I backported the changes to a branch for v1 so we can use Magik already in several plugins, but with the current grammar, the lint breaks, while in v2 it doesn't.

https://github.com/sebastiaanspeck/prism/actions/runs/24758384791

The root cause is the lookbehind assertion ((?<!\|)) in the number token. This is an ES2018 feature. In Prism v1, we use ESLint v7. To make it support the lookbehind assertions in regexes, you can add

"parserOptions": {
  "ecmaVersion": 2018
}

to .eslintrc.js (I suppose, before the rules property should work).

sebastiaanspeck mentioned this pull request Apr 13, 2026

magik: define symbol before number to match symbols with numbers #4075

Closed

sebastiaanspeck force-pushed the fix/magik branch 2 times, most recently from e210d7c to 9b3a575 Compare April 13, 2026 10:51

krn-sebastiaan force-pushed the fix/magik branch from 9b3a575 to fd5ce1a Compare April 13, 2026 12:51

sebastiaanspeck force-pushed the fix/magik branch 2 times, most recently from 504fc48 to 271dfbe Compare April 13, 2026 13:14

Apply fixes for Magik language

152703a

sebastiaanspeck force-pushed the fix/magik branch from 271dfbe to 152703a Compare April 13, 2026 13:20

sebastiaanspeck added 2 commits April 13, 2026 15:47

Add support for pipe-enclosed variables

56e52e0

Split (and fix) the different variable types

84d7ff9

sebastiaanspeck force-pushed the fix/magik branch from 9afe534 to 84d7ff9 Compare April 13, 2026 20:06

Add test case for slot

9f95a53

sebastiaanspeck and others added 3 commits April 14, 2026 17:32

Fix slot test

4efc0ef

Fix import

8a5cfbd

Simplify regex

fbcaab9

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

DmitrySharabin reviewed Apr 17, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

DmitrySharabin requested changes Apr 17, 2026

View reviewed changes

sebastiaanspeck added 2 commits April 17, 2026 20:35

Apply some fixes after code review

356a13b

Fix lint issue

c3490a0

sebastiaanspeck commented Apr 19, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

Revert change

f24130e

sebastiaanspeck added 3 commits April 19, 2026 02:19

Apply suggestion from review and fix flags

1407d3e

Add tests for global variables with ? and !

f07235b

Remove word boundary

89b96c8

Co-authored-by: Sebastiaan Speck <12570668+sebastiaanspeck@users.noreply.github.com>

sebastiaanspeck force-pushed the fix/magik branch from 13f26a0 to 89b96c8 Compare April 19, 2026 02:20

Use keyword as alias for _unset/_constant

64deafe

DmitrySharabin reviewed Apr 21, 2026

View reviewed changes

Comment thread src/languages/magik.js Outdated

sebastiaanspeck and others added 2 commits April 21, 2026 15:47

Update src/languages/magik.js

1215b98

Co-authored-by: Dmitry Sharabin <dmitrysharabin@gmail.com>

Update variable_feature.test

822f871

DmitrySharabin approved these changes Apr 21, 2026

View reviewed changes

Run prettier

0c9ed13

DmitrySharabin merged commit ded4a65 into PrismJS:v2 Apr 21, 2026
13 of 14 checks passed

sebastiaanspeck deleted the fix/magik branch April 22, 2026 14:11

Uh oh!

Conversation

sebastiaanspeck commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for dev-prismjs-com ready!

Uh oh!

github-actions Bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

No JS Changes

Uh oh!

sebastiaanspeck commented Apr 13, 2026

Uh oh!

sebastiaanspeck commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DmitrySharabin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sebastiaanspeck commented Apr 19, 2026

Uh oh!

Uh oh!

DmitrySharabin left a comment

Choose a reason for hiding this comment

Uh oh!

sebastiaanspeck commented Apr 21, 2026

Uh oh!

DmitrySharabin commented Apr 21, 2026

Uh oh!

sebastiaanspeck commented Apr 21, 2026

Uh oh!

DmitrySharabin commented Apr 21, 2026

Uh oh!

sebastiaanspeck commented Apr 21, 2026

Uh oh!

Uh oh!

DmitrySharabin commented Apr 21, 2026

Uh oh!

sebastiaanspeck commented Apr 22, 2026

Uh oh!

DmitrySharabin commented Apr 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sebastiaanspeck commented Apr 13, 2026 •

edited

Loading

netlify Bot commented Apr 13, 2026 •

edited

Loading

github-actions Bot commented Apr 13, 2026 •

edited

Loading

sebastiaanspeck commented Apr 14, 2026 •

edited

Loading