delete $ symbol, fix #353 - #354
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 55.61% 55.60% -0.01%
==========================================
Files 40 44 +4
Lines 6252 6262 +10
==========================================
+ Hits 3477 3482 +5
- Misses 2775 2780 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NikoOinonen
approved these changes
Jul 21, 2025
NikoOinonen
left a comment
Collaborator
There was a problem hiding this comment.
@huangchieh Thanks, this is better.
I also think it might be a good idea to update these two wiki pages, though I couldn’t find the source documents in the repository.
I updated those pages as well. Unfortunately the wiki is not under the git repository, so external people cannot contribute to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find it more convenient to copy the code without these
$symbols, and it also helps maintain consistency. I also think it might be a good idea to update these two wiki pages, though I couldn’t find the source documents in the repository.