Reubicar bloques#365
Open
MGonzalezx wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #361
Creé una nueva lista llamada
challengeOnlyBlocksla cual va a contener los bloques que deben existir en desafíos pero no en el selector del creador.Eliminé a la lista 'notusedBlocks' ya que quedó vaciá y estamos utilizando todos los bloques.
Modifiqué la función
availableBlocksFor()para aceptar el parámetro opcionalincludeChallengeOnly(un booleano que por defecto esfalse). Esto permite ocultar ciertos bloques en la interfaz del creador de escenarios que solo deben estar disponibles en los desafíos.Hice una corrección de Ejercicios y Bloques en donde no bastaba solo mover los bloques ya sea por error de tipeo o porque faltaba un bloque:
HayCharconecesario para el charco. Tomando como referencia el bloque en EmberHayVocalRMTpor la forma correcta:hayVocalRMT.longituden el bloqueGirarGrados. Se unificó el criterio modificandoblocks.tspara que usegrados, alineándose con la definición original enprimitives.ts.challenges.tsdonde decíaVolverAlBordeIzquierdoen lugar deVolverABordeIzquierdo.OpComparacion(de la categoríaoperators) y se añadió a la lista de bloqueschallengeOnlyBlocks. Se tomó como referencia el mismo bloque pero en ember.