You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@aristath , this PR will set autoload to false for new installs and it will update the auto load value when existing users update the option?
Should we add an upgrade script to do it automatically when plugin is updated?
I was thinking something light, like we do it is done in Comment Experience
@aristath , this PR will set autoload to false for new installs and it will update the auto load value when existing users update the option?
Yes, that is correct.
Should we add an upgrade script to do it automatically when plugin is updated?
I don't think that's necessary... The option gets updated in Plugin::update_tracked_options(), which is hooked in shutdown (in Plugin::register_hooks()), so it will be auto-updated after the 1st page-load anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR changes ensures the plugin option is not autoloaded, to improve performance.