Skip to content

fix: resolve Go module import path issue causing Docker build failure#49

Merged
Nimbus318 merged 1 commit into
Project-HAMi:mainfrom
Nimbus318:fix/go-module-import-paths
Sep 19, 2025
Merged

fix: resolve Go module import path issue causing Docker build failure#49
Nimbus318 merged 1 commit into
Project-HAMi:mainfrom
Nimbus318:fix/go-module-import-paths

Conversation

@Nimbus318

Copy link
Copy Markdown
Collaborator
  • Change module name from 'vgpu' to 'github.com/Project-HAMi/HAMi-WebUI/server'
  • Update all import paths from 'vgpu/internal/*' to proper module path
  • Fix wire dependency injection configuration

This resolves the build error:
wire: could not import vgpu/internal/conf (invalid package name: "")

Fixes the multi-arch Docker builds in GitHub Actions.

@hami-robot

hami-robot Bot commented Sep 19, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nimbus318

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hami-robot hami-robot Bot added the size/L label Sep 19, 2025
@Nimbus318
Nimbus318 force-pushed the fix/go-module-import-paths branch from ea30ef6 to e7664c2 Compare September 19, 2025 09:14
@Nimbus318
Nimbus318 force-pushed the fix/go-module-import-paths branch from d230bc6 to e1c3524 Compare September 19, 2025 09:27
@Nimbus318
Nimbus318 force-pushed the fix/go-module-import-paths branch from 9e0a0a8 to 9c06a38 Compare September 19, 2025 09:37
@hami-robot hami-robot Bot added size/XS and removed size/L labels Sep 19, 2025
…missing dependencies

- Upgrade Go version from 1.23.1 to 1.25.1 in Dockerfile to satisfy gnostic dependency requirements
  (github.com/google/gnostic@v0.7.1 requires go >= 1.24.6)
- Add missing protoc-gen-openapi dependency in Makefile install-deps target
  (protoc-gen-openapi: program not found or is not executable)
- Update CI workflow Go version to 1.25.1 for consistency

This resolves the actual build errors in GitHub Actions:
1. Go version compatibility issue with gnostic dependency
2. Missing protoc-gen-openapi tool causing protobuf generation failures
3. Subsequent wire generation failures due to missing generated files

The previous module path changes were unnecessary - the real issue was
build toolchain compatibility, not Go module configuration.

Signed-off-by: Yu Yin <yu.yin@dynamia.ai>
@Nimbus318
Nimbus318 force-pushed the fix/go-module-import-paths branch from 9c06a38 to 54548b1 Compare September 19, 2025 09:39
@Nimbus318
Nimbus318 merged commit a49f16f into Project-HAMi:main Sep 19, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant