Skip to content

fix: fix async handling and error catching issues in monitoring hooks #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nimbus318 merged 1 commit into from
Dec 2, 2025
Merged

fix: fix async handling and error catching issues in monitoring hooks #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/web/projects/vgpu/hooks/useInstantVector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const useInstantVector = (configs, parseQuery = (query) => query, times) => {
const fetchInstantData = async () => {
const reqs = configs.map(
async ({ query, totalQuery, percentQuery, cntQuery }, index) => {
if (parseQuery(query).includes('undefined')) {
if (!query || parseQuery(query).includes('undefined')) {
return;
}
if (query) {
Expand Down Expand Up @@ -47,17 +47,17 @@ const useInstantVector = (configs, parseQuery = (query) => query, times) => {
},
);

Promise.all(reqs);
await Promise.all(reqs);
};

const fetchRangeData = async () => {
const reqs = configs.map(
async ({ query, totalQuery, percentQuery }, index) => {
if (parseQuery(query).includes('undefined')) {
if (!query || parseQuery(query).includes('undefined')) {
return;
}

if (percentQuery) {
if (percentQuery && times?.value?.[0] && times?.value?.[1]) {
const percentData = await cardApi.getRangeVector({
query: parseQuery(percentQuery),
range: {
Expand All @@ -72,7 +72,7 @@ const useInstantVector = (configs, parseQuery = (query) => query, times) => {
},
);

Promise.all(reqs);
await Promise.all(reqs);
};

watchEffect(() => {
Expand Down
6 changes: 6 additions & 0 deletions packages/web/projects/vgpu/views/monitor/overview/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,9 @@ const fetchRangeData = () => {
})
.then((res) => {
v.data = res.data?.[0]?.values || [];
})
.catch((err) => {
console.error('Failed to fetch range data:', err);
});
}
}
Expand All @@ -408,6 +411,9 @@ const fetchRangeData = () => {
})
.then((res) => {
alarmData.value = res.data?.[0]?.values || [];
})
.catch((err) => {
console.error('Failed to fetch alarm data:', err);
});

};
Expand Down
Loading