Skip to content

Fix "defaultShowDrawerSidebar" typo globally #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Infinite1024Void wants to merge 8 commits into
base: main
Choose a base branch
from
+9 −10
Open

Fix "defaultShowDrawerSidebar" typo globally #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
04075e1
Fix typo in App.tsx component structure
Infinite1024Void Apr 26, 2026
42d7700
Fix typo in DrawerProvider prop name
Infinite1024Void Apr 26, 2026
7f125cd
Fix typo in DrawerProvider prop name
Infinite1024Void Apr 26, 2026
a3f46f8
Fix typo in DrawerProvider prop name
Infinite1024Void Apr 26, 2026
9b69aed
Fix typo in App.tsx
Infinite1024Void Apr 26, 2026
dd9cdcb
Fix typo in DrawerProvider prop name
Infinite1024Void Apr 26, 2026
031e198
Fix typo in useDrawer test for sidebar prop
Infinite1024Void Apr 26, 2026
76e1628
Remove global typo fix TODO comment
Infinite1024Void Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/calendar/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const App = () => {
<Router history={extraThunkArguments.history}>
<EventManagerProvider eventManager={extraThunkArguments.eventManager}>
<ApiProvider api={extraThunkArguments.api}>
<DrawerProvider defaultShowDrawerSidear={state.showDrawerSidebar}>
<DrawerProvider defaultShowDrawerSidebar={state.showDrawerSidebar}>
<CalendarModelEventManagerProvider
calendarModelEventManager={
extraThunkArguments.calendarModelEventManager
Expand Down
3 changes: 1 addition & 2 deletions applications/docs/src/app/routes/(user)/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,7 @@ function RouterDependentContainer({
return (
<EventManagerProvider eventManager={extraThunkArguments.eventManager}>
<ApiProvider api={extraThunkArguments.api}>
{/* TODO: fix typo globally */}
<DrawerProvider defaultShowDrawerSidear={showDrawerSidebar}>
<DrawerProvider defaultShowDrawerSidebar={showDrawerSidebar}>
<ErrorBoundary big component={<StandardErrorPage big />}>
{/* TODO: remove this once the temporary "Trash" homepage view implementation is cleaned up */}
<UserSettingsProvider
Expand Down
2 changes: 1 addition & 1 deletion applications/drive/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ const App = () => {
<CompatRouter>
<EventManagerProvider eventManager={extraThunkArguments.eventManager}>
<ApiProvider api={extraThunkArguments.api}>
<DrawerProvider defaultShowDrawerSidear={state.showDrawerSidebar}>
<DrawerProvider defaultShowDrawerSidebar={state.showDrawerSidebar}>
<ErrorBoundary
big
component={<StandardErrorPage big />}
Expand Down
2 changes: 1 addition & 1 deletion applications/lumo/src/app/entrypoint/auth/AuthApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ const AuthApp = () => {
<ProtonStoreProvider store={state.store}>
<AuthenticationProvider store={extraThunkArguments.authentication}>
<ApiProvider api={extraThunkArguments.api}>
<DrawerProvider defaultShowDrawerSidear={state.showDrawerSidebar}>
<DrawerProvider defaultShowDrawerSidebar={state.showDrawerSidebar}>
<FlagProvider unleashClient={extraThunkArguments.unleashClient} startClient={false}>
<Router history={extraThunkArguments.history}>
<EventManagerProvider eventManager={extraThunkArguments.eventManager}>
Expand Down
2 changes: 1 addition & 1 deletion applications/mail/src/app/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const App = () => {
calendarModelEventManager={extraThunkArguments.calendarModelEventManager}
>
<ApiProvider api={extraThunkArguments.api}>
<DrawerProvider defaultShowDrawerSidear={state.showDrawerSidebar}>
<DrawerProvider defaultShowDrawerSidebar={state.showDrawerSidebar}>
<EasySwitchStoreProvider>
<EasySwitchStoreInitializer>
<ErrorBoundary component={<StandardErrorPage big />}>
Expand Down
4 changes: 2 additions & 2 deletions packages/components/hooks/drawer/useDrawer.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ const fireMessage = async (data: object, origin = 'https://calendar.proton.me')
});
};

const createWrapper = (defaultShowDrawerSidear?: boolean) => {
const createWrapper = (defaultShowDrawerSidebar?: boolean) => {
const DrawerProviderWrapper = ({ children }: { children: ReactNode }) => (
<DrawerProvider defaultShowDrawerSidear={defaultShowDrawerSidear}>{children}</DrawerProvider>
<DrawerProvider defaultShowDrawerSidebar={defaultShowDrawerSidebar}>{children}</DrawerProvider>
);
return DrawerProviderWrapper;
};
Expand Down
4 changes: 2 additions & 2 deletions packages/components/hooks/drawer/useDrawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ export default function useDrawer() {

export const DrawerProvider = ({
children,
defaultShowDrawerSidear,
defaultShowDrawerSidebar,
}: {
children: ReactNode;
defaultShowDrawerSidear?: boolean;
defaultShowDrawerSidebar?: boolean;
}) => {
const authentication = useAuthentication();
const api = useApi();
Expand Down