refactor(net): remove the dead java config module - #3207
Open
BryanFRD wants to merge 1 commit into
Open
Conversation
BryanFRD
force-pushed
the
refactor/drop-dead-java-config
branch
from
September 4, 2026 07:30
b8e1716 to
36b4a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
net/java/config/is a closed island of 337 lines that nothing reaches. The Javaconfig phase was reimplemented on
PendingConnectioninnet/java/pending.rsandnet/java/login/, and the oldimpl JavaClientversion was never deleted. Thematching names on the two types make it easy to miss.
Every handler has a live replacement:
impl JavaClient)impl PendingConnection)handle_client_information_configpending.rshandle_plugin_messagepending.rshandle_resource_pack_responsepending.rshandle_config_cookie_responsepending.rshandle_known_packslogin/known_packs.rssend_known_packslogin/login_acknowledged.rshandle_config_acknowledgedRegistry::get_synced(version)handle_config_keep_aliveHANDSHAKE_IDLE_TIMEOUThandle_config_acknowledgedandsend_known_packswere only called from otherfunctions inside the module.
build_dimension_nbtwas re-exported to the parentwith no consumer, and
BRAND_CHANNEL_PREFIXis duplicated verbatim inpending.rs.Change
Delete the directory, its
pub mod config;declaration, and thePacketHandlerResultimport it was the last user of.No behaviour change:
cargo check --all-featuresis clean, with no new warnings.