Skip to content

refactor(net): remove the dead java config module - #3207

Open
BryanFRD wants to merge 1 commit into
Pumpkin-MC:masterfrom
BryanFRD:refactor/drop-dead-java-config
Open

refactor(net): remove the dead java config module#3207
BryanFRD wants to merge 1 commit into
Pumpkin-MC:masterfrom
BryanFRD:refactor/drop-dead-java-config

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Problem

net/java/config/ is a closed island of 337 lines that nothing reaches. The Java
config phase was reimplemented on PendingConnection in net/java/pending.rs and
net/java/login/, and the old impl JavaClient version was never deleted. The
matching names on the two types make it easy to miss.

Every handler has a live replacement:

Removed (impl JavaClient) Live (impl PendingConnection)
handle_client_information_config pending.rs
handle_plugin_message pending.rs
handle_resource_pack_response pending.rs
handle_config_cookie_response pending.rs
handle_known_packs login/known_packs.rs
send_known_packs login/login_acknowledged.rs
handle_config_acknowledged superseded by Registry::get_synced(version)
handle_config_keep_alive obsolete: keep-alives are only sent in the play loop, the pending phase uses HANDSHAKE_IDLE_TIMEOUT

handle_config_acknowledged and send_known_packs were only called from other
functions inside the module. build_dimension_nbt was re-exported to the parent
with no consumer, and BRAND_CHANNEL_PREFIX is duplicated verbatim in pending.rs.

Change

Delete the directory, its pub mod config; declaration, and the
PacketHandlerResult import it was the last user of.

No behaviour change: cargo check --all-features is clean, with no new warnings.

@BryanFRD
BryanFRD requested a review from Snowiiii as a code owner September 3, 2026 08:34
@RoosterBooster007 RoosterBooster007 added protocol About Packets or the Protocol refactor Clean up, clean up / Everybody, everywhere labels Sep 3, 2026
@BryanFRD
BryanFRD force-pushed the refactor/drop-dead-java-config branch from b8e1716 to 36b4a76 Compare September 4, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

protocol About Packets or the Protocol refactor Clean up, clean up / Everybody, everywhere

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants