Reuse inner allocation in collect_bicolor_runs#1578
Merged
jakelishman merged 1 commit intoQiskit:mainfrom Apr 17, 2026
Merged
Conversation
This commit removes an unecessary iteration of every iteration of the loop inside collect_bicolor_runs(). The vec collection on every iteration of the loop results in a lot of allocations and frees for every node in the graph. We can reuse a single vec between each iteration and avoid this memory pressure.
jakelishman
approved these changes
Apr 17, 2026
gqf2008
pushed a commit
to gqf2008/rustworkx
that referenced
this pull request
Apr 26, 2026
This commit removes an unecessary iteration of every iteration of the loop inside collect_bicolor_runs(). The vec collection on every iteration of the loop results in a lot of allocations and frees for every node in the graph. We can reuse a single vec between each iteration and avoid this memory pressure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes an unecessary iteration of every iteration of the loop inside collect_bicolor_runs(). The vec collection on every iteration of the loop results in a lot of allocations and frees for every node in the graph. We can reuse a single vec between each iteration and avoid this memory pressure.