Replace deprecated tic/toc timers with qe.Timer in kesten_processes#330
Open
devthedevil wants to merge 1 commit into
Open
Replace deprecated tic/toc timers with qe.Timer in kesten_processes#330devthedevil wants to merge 1 commit into
devthedevil wants to merge 1 commit into
Conversation
✅ Deploy Preview for incomparable-parfait-2417f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mmcky
reviewed
Jul 9, 2026
| a, b, e = jax.tree.map(jnp.exp, (a, b, e)) | ||
| # Update the cross-section of firms | ||
| s = jnp.where(s < s_bar, e, a * s + b) | ||
| s = jnp.where(s < s_bar, e_t, a_t * s + b_t) |
Contributor
There was a problem hiding this comment.
@devthedevil I don't think this is correct unless we update variables elsewhere. Please review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #329.
quanteconis deprecating the Matlab-liketic/tac/toctimers in favour of theTimercontext manager (QuantEcon/QuantEcon.py#833).lectures/kesten_processes.mdwas the only lecture in this repo still using the old API.Change
from quantecon import tic, tocimport (the lecture already doesimport quantecon as qe).tic()/toc()pairs wrapping a single timed call with the equivalentwith qe.Timer():context manager, e.g.:This is a purely mechanical, behavior-preserving swap —
qe.Timer()prints elapsed time on exit by default, matchingtoc()'s existing behavior.Testing
This is a documentation/lecture source file (no associated unit tests). Verified by inspecting the
quantecon.util.timing.Timercontext-manager implementation upstream to confirmwith qe.Timer():is a drop-in replacement for thetic()/toc()pair used here.