Fix incorrect $(INSTALL_DIR) shell expansion in build-without-conan.md - #2247
Merged
Merged
Conversation
The nanobind cmake command used command-substitution syntax
$(INSTALL_DIR) instead of variable expansion ${INSTALL_DIR}, unlike
every other cmake invocation in the document.
Fixes Quantinuum#2244
AnitaGeorge404
force-pushed
the
install-DIR
branch
from
September 25, 2026 13:49
5c19eae to
20aa1a0
Compare
cqc-alec
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-without-conan.md, which used command-substitution syntax$(INSTALL_DIR)instead of shell variable expansion${INSTALL_DIR}, inconsistent with every othercmakecommand in the document.INSTALL_DIRin the file; this was the only one using the incorrect syntax.Fixes #2244
Test plan
git diff— single-line, documentation-only changeINSTALL_DIRreferences inbuild-without-conan.mdto confirm no other inconsistencies remain