Skip to content

Fix CI: Remove unused @variables import and fix formatting in ModelingToolkitExt#487

Merged
oameye merged 3 commits intodependabot/github_actions/crate-ci/typos-1.43.3from
copilot/fix-ci-issues
Feb 10, 2026
Merged

Fix CI: Remove unused @variables import and fix formatting in ModelingToolkitExt#487
oameye merged 3 commits intodependabot/github_actions/crate-ci/typos-1.43.3from
copilot/fix-ci-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 10, 2026

Checklist

Thank you for contributing to HarmonicBalance.jl! Please make sure you have finished the following tasks before finishing the PR.

  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Fixed two CI failures in ext/ModelingToolkitExt.jl:

  1. ExplicitImports Check: @variables macro was imported but never used in executable code (only appeared in documentation examples)
  2. JuliaFormatter Check: Import statement formatting needed adjustment to meet style requirements

Changes:

  • Removed @variables from Symbolics imports in ext/ModelingToolkitExt.jl
  • Reformatted Symbolics import statement to single line as required by JuliaFormatter

All other Symbolics imports (simplify, Equation, substitute, Num, expand, unwrap, arguments, wrap) remain and are actively used.

Related issues or PRs

Fixes continuous integration test failures.

Additional context

N/A


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix continuous integration issues Fix CI: Remove unused @variables import from ModelingToolkitExt Feb 10, 2026
Copilot AI requested a review from oameye February 10, 2026 09:30
@oameye oameye marked this pull request as ready for review February 10, 2026 09:35
@oameye
Copy link
Copy Markdown
Member

oameye commented Feb 10, 2026

@copilot Can you fix the formatting CI failure?

Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 10, 2026

@copilot Can you fix the formatting CI failure?

Fixed the formatting issue by putting the Symbolics imports on a single line as required by JuliaFormatter. Commit: 3015af9

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/JuliaLang/JuliaSyntax.jl/tarball/937da4713526b96ac9a178e2035019d3b78ead4a
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • https://api.github.com/repos/JuliaLang/PrecompileTools.jl/tarball/07a921781cab75691315adc645096ed5e370cb77
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • https://api.github.com/repos/JuliaPackaging/Preferences.jl/tarball/522f093a29b31a93e34eaea17ba055d850edea28
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • https://api.github.com/repos/MichaelHatherly/CommonMark.jl/tarball/65ea18ada9814f09c5013924c42fe8b53d6ee467
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • https://api.github.com/repos/domluna/JuliaFormatter.jl/tarball/ec5e99ad66c51b6fcd3dbab6655b17118a29a588
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • https://api.github.com/repos/vtjnash/Glob.jl/tarball/83cb0092e2792b9e3a865b6655e88f5b862607e2
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (http block)
  • pkg.julialang.org
    • Triggering command: /usr/bin/julia julia -e using Pkg; Pkg.add(PackageSpec(name=&#34;JuliaFormatter&#34;)) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Fix CI: Remove unused @variables import from ModelingToolkitExt Fix CI: Remove unused @variables import and fix formatting in ModelingToolkitExt Feb 10, 2026
@oameye oameye merged commit c37f431 into dependabot/github_actions/crate-ci/typos-1.43.3 Feb 10, 2026
2 checks passed
@oameye oameye deleted the copilot/fix-ci-issues branch February 10, 2026 09:43
oameye added a commit that referenced this pull request Feb 10, 2026
* build(deps): bump crate-ci/typos from 1.42.0 to 1.43.3

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.42.0 to 1.43.3.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.42.0...v1.43.3)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-version: 1.43.3
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fix CI: Remove unused @variables import and fix formatting in ModelingToolkitExt (#487)

* Initial plan

* Remove unused @variables import from ModelingToolkitExt

Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>

* Fix formatting: Put Symbolics imports on single line

Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>

* [WIP] Update typos dependency from 1.42.0 to 1.43.3 (#488)

* Initial plan

* Remove unused @setup_workload and @compile_workload imports

Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: oameye <57623933+oameye@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants