Skip to content

Attach to new disposable: omit template on deletion, not shutdown #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Feb 7, 2026
Merged

Attach to new disposable: omit template on deletion, not shutdown #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions qui/devices/device_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,12 +412,17 @@ def pci_action(self, vm, _event, **_kwargs):
def remove_domain_item(self, _submitter, _event, vm, **_kwargs):
# In a perfect world, core should trigger `device-unassign:pci` event
# for PCI devices attached to an HVM before actually removing it and
# this method should not be necessary. But we are not certain :/
# this code should not be necessary. But we are not certain :/
for wrapped_vm in self.dormant_usbvms:
if wrapped_vm.name == vm:
self.dormant_usbvms.discard(wrapped_vm)
break

for wrapped_vm in self.dispvm_templates:
if wrapped_vm.name == vm:
self.dispvm_templates.discard(wrapped_vm)
break

def update_single_feature(self, _vm, _event, feature, value=None, oldvalue=None):
if not value:
new = set()
Expand Down Expand Up @@ -654,7 +659,6 @@ def vm_shutdown(self, vm, _event, **_kwargs):
self.dormant_usbvms.add(wrapped_vm)

self.vms.discard(wrapped_vm)
self.dispvm_templates.discard(wrapped_vm)

devs_to_remove = []
for dev in self.devices.values():
Expand Down