Keep state files only when SaveOnExit is true#23
Conversation
|
I read the thread upstream. It seems that they understand there is a problem but want to fix it elsewhere. If the thread is merged upstream, post a comment so we are notified. |
|
Absolutely, will do. |
|
If I read the discussion right, indeed alternative approach was considered, but in the end returned to the initial version. So, this PR should still be good once merged upstream. Or maybe we could merge this one even before, as it's likely the change will be accepted in this shape. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026061502-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests56 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 21 fixed
Unstable testsDetails
Performance TestsPerformance degradation:14 performance degradations
Remaining performance tests:95 tests
|
4 participants
Upstream MR here - Original MR by @mati7337 was conflicting with xfwm4's master.
SaveOnExit should now behave as the user expects, and this would make QubesOS (which uses xfwm4 by default) more secure since VM's shouldn't log the window titles of everything the user opens if the user explicitly states that
SaveOnExit=false.