Skip to content

Fix reporting error status for multi-command actions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Mar 21, 2026
Merged

Fix reporting error status for multi-command actions #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions _utils/qubes_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,14 +223,16 @@ def linefeed(text):
if status.comment.strip():
comment += linefeed(comment) + status.comment

# 'retcode' - Determine retcode
# Use 'result' over 'retcode' if result is not None as 'retcode'
# reflects last run state, where 'result' is set explicitly
if status.result is not None:
retcode = not status.result
# 'retcode' - Determine retcode based on first failure
if status_mode in ['all']:
# Use 'result' over 'retcode' if result is not None as
# 'retcode' reflects last run state, where 'result' is set
# explicitly
if status.result is not None:
retcode = retcode or not status.result

elif status.retcode and status_mode in ['all']:
retcode = status.retcode
else:
retcode = retcode or status.retcode

if status.result and test_mode:
status.result = None
Expand Down